Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSimulation/*: Change return type of ESProducers to unique_ptr. #22155

Merged
merged 1 commit into from Feb 18, 2018
Merged

FastSimulation/*: Change return type of ESProducers to unique_ptr. #22155

merged 1 commit into from Feb 18, 2018

Conversation

gartung
Copy link
Member

@gartung gartung commented Feb 7, 2018

Remove shared_ptr class member that is not needed.

Remove shared_ptr class member that is not needed.
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

FastSimulation/ParticlePropagator
FastSimulation/TrackerSetup

@cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Feb 8, 2018

@Dr15Jones please test

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25981/console Started: 2018/02/08 16:49

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22155/25981/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22155/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2464162
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2463992
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.660000000069 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@civanch
Copy link
Contributor

civanch commented Feb 17, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fd93201 into cms-sw:master Feb 18, 2018
@gartung gartung deleted the FastSimulation-ESProducers-returntype branch March 2, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants