Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiStrip cluster charge cut @HLT #2224

Merged

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jan 29, 2014

synchronize HLTTrackClusterRemover to the offline version w/ SiStripClusterChargeCut

the parameter which handles the switch of this cut (doStripChargeCheck) is set to FALSE as default value

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_1_X.

SiStrip cluster charge cut @HLT

It involves the following packages:

RecoLocalTracker/SubCollectionProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@gpetruc, @cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre3, CMSSW_7_1_0_pre2 Feb 5, 2014
@slava77
Copy link
Contributor

slava77 commented Feb 7, 2014

+1

this (abe9751) is the same as #2245

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 7, 2014
…geCut@HLT

Reco -- SiStrip cluster charge cut @HLT
@ktf ktf merged commit a549790 into cms-sw:CMSSW_7_1_X Feb 7, 2014
@VinInn VinInn mentioned this pull request Feb 19, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants