New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undefined behaviour in MixCollection<T>::MixItr #22270
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22270/3459 |
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: SimDataFormats/CrossingFrame @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Seems that with the PR-test statistics there is no effect (the reported differences come from LogErrors). |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Resolves #22266. Add internal counter to the
MixItr
counting the number of iterated elements, and use that foroperator!=()
. TheMixCollection<T>::end()
is implemented by calculating the number of all signal and pileup objects from all the containedCrossingFrame<T>
s.Tested in CMSSW_10_1_X_2018-02-18-2300. Expecting changes at some level (probably not much, given that this "randomness" has been there since 2005).