Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DQM monitoring code for empty MET problem #22277

Merged
merged 2 commits into from Feb 22, 2018

Conversation

bobaekim
Copy link
Contributor

To fix empty MET plots, configuration files of DQM monitoring are modified.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bobaekim (Bobae Kim) for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @drkovalskyi, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26199/console Started: 2018/02/20 17:25

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22277/26199/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 28
  • DQMHistoTests: Total histograms compared: 2497024
  • DQMHistoTests: Total failures: 3808
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2493040
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 5.26999999984 KiB( 23 files compared)
  • Checked 115 log files, 9 edm output root files, 28 DQM output files

Copy link
Contributor

@fabiocos fabiocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, are these last lines intended? Why no path is defined (the line with the fixed paths is commented)?

@bobaekim
Copy link
Contributor Author

Dear fabiocos,
Yes. No trigger required for denominator when I checked 9_2_X configuration file.
Due to muon trigger of denominator, no events passed. So MET plots are empty.
If you know about denominator trigger, please let me know.
Thank you. :)

Best regards,
Bobae

@fabiocos
Copy link
Contributor

@bobaekim ok, thanks for the clarification

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e6d81c9 into cms-sw:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants