DQM: SiPixelPhase1- Added Big Pixel Charge Plots #22324
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22324/3535 |
|
A new Pull Request was created by @emacdonald16 for master. It involves the following packages: DQM/SiPixelPhase1Clusters @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
hello @vazzolini, @kmaeshima, @dmitrijus, @jfernan2, @vanbesien : |
|
@hbecerri FYI |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Tested at: 1689490 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
Dear @fabiocos , may I ask the motivation for not having included this in 10_1 while it has been signed for 2 weeks (and explicitely asked in this github conversation)? Shall we now go to the proces of backport ?.......... :( And if yes when the next 10_1 release is going to be built? We indeed have to be sure this big pixel monitorig is in place in the software for data taking .... |
|
Dear @boudoul this arrived in the "closed" period of 10_1_X, where I had to do a selection in the middle of several other priorities piling up. Several other things will have to be backported, we needed to close anyway. If you provide a backport, please mark it in next ORP spreadsheet as needed for operations, 10_1_1 will be built for sure in time for the beginning of the ramp-up, but if there is some urgent need for operations we may have patches. |
|
@boudoul I saw it, thanks, we can integrate it when it is signed, we need to have a number of things into a 10_1_1 anyway soon |
|
Thank you @fabiocos ! |
DQM: SiPixelPhase1- Added Big Pixel Charge Plots [Backport for 10_1_X of #22324 ]
Added the charge of the big pixels for the barrel and the forward region, as well as per layer and per disk
For inclusive clusters and on-track clusters (for inclusive clusters the plots are disabled by default)