Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input parameters for PU-weighted MVAIso #22386

Merged

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Feb 28, 2018

As title of this PR says it fixes an input parameter for PU-weighted MVAIso tau-Ids. The effect should be seen as (moderate) change of "ByIsolationMVArun2v1PW" tau-Ids.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mbluj
Copy link
Contributor Author

mbluj commented Feb 28, 2018

@roger-wolf @steggema you might be interested in following this PR

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for master.

It involves the following packages:

RecoTauTag/Configuration

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 28, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26372/console Started: 2018/02/28 10:36

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22386/26372/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22386/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 192 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2499373
  • DQMHistoTests: Total failures: 1667
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497530
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.07000000001 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Mar 1, 2018

The changes in the "ByIsolationMVArun2v1PW" tau-Ids are rather evident, being the output of the discriminator much more peaked towards the value of 1, see e.g. RunSinglePh2017B wf 136.788:
image
image

The fix is rather obvious, anyhow, and I suppose that the change, although not "moderate" goes in the right direction. Please @mbluj comment.

@mbluj
Copy link
Contributor Author

mbluj commented Mar 1, 2018

The change goes indeed into expected direction.

Regardless, I please find below a set of MC plots for genuine and fake taus as reference.

@perrotta
Copy link
Contributor

perrotta commented Mar 1, 2018

+1

  • it fixes a mis-typed input parameter for PU-weighted MVAIso tau-Ids
  • Effects on the tau-id outputs follow the expectation

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 2, 2018

+1

@cmsbuild cmsbuild merged commit f993a20 into cms-sw:master Mar 2, 2018
@mbluj mbluj deleted the CMSSW_10_1_X_fixInputForIsoMVArun2PW branch October 10, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants