New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix input parameters for PU-weighted MVAIso #22386
Fix input parameters for PU-weighted MVAIso #22386
Conversation
The code-checks are being triggered in jenkins. |
@roger-wolf @steggema you might be interested in following this PR |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22386/3608 |
A new Pull Request was created by @mbluj for master. It involves the following packages: RecoTauTag/Configuration @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
The changes in the "ByIsolationMVArun2v1PW" tau-Ids are rather evident, being the output of the discriminator much more peaked towards the value of 1, see e.g. RunSinglePh2017B wf 136.788: The fix is rather obvious, anyhow, and I suppose that the change, although not "moderate" goes in the right direction. Please @mbluj comment. |
The change goes indeed into expected direction. Regardless, I please find below a set of MC plots for genuine and fake taus as reference. |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
As title of this PR says it fixes an input parameter for PU-weighted MVAIso tau-Ids. The effect should be seen as (moderate) change of "ByIsolationMVArun2v1PW" tau-Ids.