Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra Geant4 Physics List #22491

Merged
merged 3 commits into from Mar 7, 2018
Merged

Extra Geant4 Physics List #22491

merged 3 commits into from Mar 7, 2018

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Mar 6, 2018

An extra PhysicsList in whihc hadronic physics is configured with the same as in Geant4 10.2 overlap between the Berini cascade and the FTFP string model (4 - 5) GeV. This Physics List may be used for tests.

No change in mainstream production is expected.

@cmsbuild cmsbuild added this to the CMSSW_10_1_X milestone Mar 6, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

The code-checks are being triggered in jenkins.

@civanch
Copy link
Contributor Author

civanch commented Mar 6, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22491/3779

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22491/3779/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22491/3779/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22491/3797

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Mar 7, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26635/console Started: 2018/03/07 10:24

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

-1

Tested at: d1bf96e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22491/26635/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_EML.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/QGSPCMS_FTFP_BERT_EMZ.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/module.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_HP_EML.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/module.cc:9:34: fatal error: FTFPCMS_BERT_EMM_TRK.h: No such file or directory
 #include "FTFPCMS_BERT_EMM_TRK.h"
                                  ^
compilation terminated.
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/module.cc:9:34: fatal error: FTFPCMS_BERT_EMM_TRK.h: No such file or directory
 #include "FTFPCMS_BERT_EMM_TRK.h"
  • Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/FTFCMS_BIC.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_ATL_EMM.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/QGSPCMS_FTFP_BERT_EML.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_EMV.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/DummyPhysics.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/module.cc:9:10: fatal error: 'FTFPCMS_BERT_EMM_TRK.h' file not found
#include "FTFPCMS_BERT_EMM_TRK.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/QGSPCMS_FTFP_BERT_EMM.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-06-2300/src/SimG4Core/PhysicsLists/plugins/QGSPCMS_FTFP_BERT_EMY.cc

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22491/3800

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

Pull request #22491 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

@civanch
Copy link
Contributor Author

civanch commented Mar 7, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26636/console Started: 2018/03/07 11:00

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

+1
Tested at: bdeb9c1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22491/26636/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22491/26636/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2480211
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2480034
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.03999999998 KiB( 21 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@civanch
Copy link
Contributor Author

civanch commented Mar 7, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2018

+1

@cmsbuild cmsbuild merged commit 3507634 into cms-sw:master Mar 7, 2018
@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2018

@civanch I have verified that this runs smoothly, as I assume you had done. Is this expected to provide exactly the same results as Geant4 10.2, or algorithms behind have changed in some way with the new Geant4 version?

@civanch
Copy link
Contributor Author

civanch commented Mar 8, 2018

@fabiocos , this PhysicsList uses the same transition between Bertini and FTFP as in 10.2. It should provide nearly the same results but not exactly the same. Too many technical and other changes between 10.2 and 10.4.

@fabiocos
Copy link
Contributor

fabiocos commented Mar 8, 2018

@civanch as I was guessing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@civanch @cmsbuild @fabiocos