Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Easy Disabling/Enabling of E/gamma HLT track matching cuts #22525

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Sam-Harper
Copy link
Contributor

At startup, the ECAL endcap is often missaligned w.r.t to the tracker which impacts the track matching cuts.

This has been the case for 2015, 2016 and 2017 and will be the case for 2018. In the past, we have manually changed the cuts (well via scripts) to fully relax the endcap cuts. Every year we have partially messed this up (some triggers slip through the cracks etc). So this year, we're controlling this with a central bool which can be easily toggled. When toggled, it zeros (or sets it to an other appropriate variable) all track matching cuts in the endcap. Right now it does it for all produced values including E/p which is probably not strickly necessary but this is on the safe side.

hltEgammaGsfTrackVars.useDefaultValuesForEndcap = cms.bool(True) and all E/gamma track cuts will automatically pass for endcap electrons.

@Martin-Grunewald

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

A new Pull Request was created by @Sam-Harper for master.

It involves the following packages:

RecoEgamma/EgammaHLTProducers

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@battibass, @jainshilpi, @lgray, @calderona, @HuguesBrun, @drkovalskyi, @varuns23, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26698/console Started: 2018/03/08 16:48

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22525/26698/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2484711
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2484534
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.00000000012 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 9, 2018

+1

@cmsbuild cmsbuild merged commit 2146f40 into cms-sw:master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants