Require ability to produce in Runs/Lumis if Run/Lumi product declared

[wddgit]

No description provided.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22560/3885

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

FWCore/Framework
FWCore/Sources

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26747/console Started: 2018/03/09 22:13

[Dr15Jones]

Instead of using InRun or InLumi for our test modules, I'd rather use the new explicit Transition enums.

[wddgit]

please abort test

[cmsbuild]

Jenkins tests are aborted.

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26750/console Started: 2018/03/09 22:43

[cmsbuild]

-1

Tested at: b540731

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22560/26767/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test EcalIntercalib_update_test had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22560/26767/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2484711
• DQMHistoTests: Total failures: 24
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2484511
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.01000000012 KiB( 22 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[wddgit]

please test

Unit test failure is not related, because it was occurring in the IBs also without these changes around that time. The differences should not be related either, but trying again just to see if they go away ... The only difference that should be possible is an exception where one was not being thrown before.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26794/console Started: 2018/03/12 15:56

[cmsbuild]

+1
Tested at: b540731
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22560/26794/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22560/26794/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2477919
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2477742
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.839999999938 KiB( 22 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

+1