Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle root6 class naming #2260

Merged
merged 1 commit into from Jan 31, 2014
Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jan 31, 2014

This pull request fixes the fatal exceptions seen in some of the ROOT6 relvals.
In ROOT 6, the normalized names of three types are different than those used by Reflex in ROOT5.
The code calculating the friendly class name for the purpose of branch naming did not handle the new names.
So, a class name containing Long64_t (the ROOT6 name for long long) was not translated. The framework cannot handle underscores in friendly class names, since underscore is a field separator in branch names.
This request fixes this problem, so the affected relvals will get further along.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X.

Handle root6 class naming

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

ktf added a commit that referenced this pull request Jan 31, 2014
ROOT6 -- Handle root6 class naming
@ktf ktf merged commit 465041b into cms-sw:CMSSW_7_1_ROOT6_X Jan 31, 2014
@wmtan wmtan deleted the HandleROOT6CLassNaming branch January 31, 2014 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants