Add missing dictionaries needed for ROOT 6. #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_1_X. Add missing dictionaries needed for ROOT 6. It involves the following packages: DataFormats/ParticleFlowReco @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks. |
ktf
added a commit
that referenced
this pull request
Feb 1, 2014
ROOT6 -- Add missing dictionaries needed for ROOT 6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing dictionaries needed for ROOT 6. These dictionaries are meaningful and harmless for ROOT 5, so this is being submitted to the main 7_1_X branch to maintain commonality for this package.
This request will fix the fatal exception seen in relval 5.0 in the ROOT6 branch, once it is carried into the ROOT6 branch.
This request was tested successfully with the short relval matrix, which includes test 5.0.
As this is a purely technical change, signatures should be bypassed if not signed in a timely manner.
Note that the abstract destructor of PFLayer prevented the dictionary from compiling, so needed to be corrected. PFLayer does not need a virtual destructor because no class is ever derived from it.