Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a pt3 member to L1TJetsMatching class, for HLT development #22649

Merged
merged 1 commit into from Mar 21, 2018

Conversation

albertdow
Copy link
Contributor

@albertdow albertdow commented Mar 16, 2018

This change adds a new member to the L1TJetsMatching class (pt3Min_) that allows one to use the L1TJetsMatching module and it's 'ThreeJets' output collection when pt1Min = pt2Min. The only triggers that use this module are VBF + MET and VBF + Tau triggers.

The VBF + Tau triggers under development are
HLT_(VBF_DoubleJet115_40)_DiTau_20
HLT_(VBF_DoubleJet40)_DiTau_115_20
HLT_(VBF_DoubleJet40)_+SingleJet115_DiTau_20.
Especially for the third case this change is required.

Note:
The VBF + MET configs should remain unchanged with this addition, since the default setting of pt3Min_ is set to the same as the pt1Min_ used in all of its configurations, namely 110 GeV (see hltL1TPFJetsMatching which is the filter used in all the VBF + MET triggers HLT_DiJet110_35_Mjj650_PFMET*_v and HLT_TripleJet110_35_Mjj650_PFMET*_v).

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @albertdow for master.

It involves the following packages:

RecoTauTag/HLTProducers

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26928/console Started: 2018/03/16 19:03

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22649/26928/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2477528
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2477351
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.13000000017 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 19733ac into cms-sw:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants