Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relval steps for Charmonium PD and MuonPOGSkim (Restart from newer IB) #22665

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

kfjack
Copy link
Contributor

@kfjack kfjack commented Mar 19, 2018

Add relval steps for MuonPOGSkim and MuonPOGJPsiSkim, restart from newer IB.

MuonPOGSkim is added to the SingleMuon PD relvals
Add new workflow for Charmonium PD and MuonPOGJPsiSkim
For testing MuonPOGSkim with 2017F relval: 136.835
For testing MuonPOGJPsiSkim with 2017F relval: 136.848

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kfjack (Kai-Feng Chen) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@GurpreetSinghChahal, @cmsbuild, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @ebrondol, @ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@prebello
Copy link
Contributor

please test workflow 136.835,136.848

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26949/console Started: 2018/03/19 14:14

@cmsbuild
Copy link
Contributor

-1

Tested at: 90f1ad1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22665/26949/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.848 step2

runTheMatrix-results/136.848_RunCharmonium2017F+RunCharmonium2017F+HLTDR2_2017+RECODR2_2017reHLT_skimCharmonium_Prompt+HARVEST2017/step2_RunCharmonium2017F+RunCharmonium2017F+HLTDR2_2017+RECODR2_2017reHLT_skimCharmonium_Prompt+HARVEST2017.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@kfjack
Copy link
Contributor Author

kfjack commented Mar 19, 2018

Somehow the input raw files for Charmonium PD are not available from the servers. Could we retest it again? Or try the workflows for other era, e.g. 136.844 for 2017B, 136.845 for 2017C, 136.846 for 2017D, 136.847 for 2017E?

@fabozzi
Copy link
Contributor

fabozzi commented Mar 19, 2018

We should check if they are available at CERN T2 (if not, we have to request a transfer to disk)

@kfjack
Copy link
Contributor Author

kfjack commented Mar 19, 2018

Ok let me check!
Update: I think we can test with 136.845 first since 2017C is partially available on CERN T2.

@fabozzi
Copy link
Contributor

fabozzi commented Mar 21, 2018

please test workflow 136.835,136.845

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 21, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27018/console Started: 2018/03/21 14:24

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fabozzi
Copy link
Contributor

fabozzi commented Mar 21, 2018

@kfjack can you ask the skim contacts to check the output of this test before we sign off?

@kfjack
Copy link
Contributor Author

kfjack commented Mar 21, 2018

@fabozzi Sure!
@sscruz Could you help to check if the output of this relval test fits your needs? Many thanks. (Another mail sent to the original discussion thread.)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22665/27018/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22665/136.835_RunSingleMu2017F+RunSingleMu2017F+HLTDR2_2017+RECODR2_2017reHLT_skimSingleMu_Prompt_Lumi+HARVEST2017_L1TMuDQM
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22665/136.845_RunCharmonium2017C+RunCharmonium2017C+HLTDR2_2017+RECODR2_2017reHLT_skimCharmonium_Prompt+HARVEST2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2497880
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497703
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.43000000014 KiB( 22 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@kfjack
Copy link
Contributor Author

kfjack commented Mar 22, 2018

@fabozzi I received the confirmation, the skim content is okay.

@fabozzi
Copy link
Contributor

fabozzi commented Mar 22, 2018

+1

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@fabozzi @prebello are all the needed input files available now? Deploying tests that systematically fail for several days is not very useful.

@smuzaffar FYI

@fabozzi
Copy link
Contributor

fabozzi commented Mar 27, 2018

We have tested on the datasets available at CERN T2. Should we ask a Phedex transfer also for the IB?

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c07e228 into cms-sw:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants