Jet ID update to the Run2017 prescription (backport to 94X)

[knash]

This is a backport of #22323 to 94X

[cmsbuild]

A new Pull Request was created by @knash for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/SelectorUtils

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Jet ID update to the Run2017 prescription #22323

[arizzi]

@fabiocos should we base this on the AN branch? (it is relevant only for analysis)

[slava77]

@knash
please edit the PR title to be more descriptive of the change.
E.g. "Jet ID update to the Run2017 prescription"

[perrotta]

backport of #22323

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26966/console Started: 2018/03/19 23:40

[cmsbuild]

+1
Tested at: fd242c9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22671/26966/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22671/26966/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2718773
• DQMHistoTests: Total failures: 109
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2718502
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 107 log files, 9 edm output root files, 26 DQM output files

[perrotta]

This PR reverts the fix already merged in 94X with #22294
I see no reason why PhysicsTools/SelectorUtils/interface/PFJetIDSelectionFunctor.h is different in 94X with respect to the master: please synchronize

[veelken]

Hi, I confirm that the fix in PR #22294 should be included in this PR also. I would also expect that the PFJetIDSelectionFunctor.h is identical in the master branch and in 94X.

[cmsbuild]

Pull request #22671 was updated. @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26996/console Started: 2018/03/20 18:14

[cmsbuild]

+1
Tested at: c91fba3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22671/26996/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22671/26996/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2718773
• DQMHistoTests: Total failures: 105
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2718506
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 107 log files, 9 edm output root files, 26 DQM output files

[perrotta]

+1

• Identical to Jet ID update to the Run2017 prescription #22323, merged in the master
• This is analysis code, with no effect on reco/miniAOD outputs,

[gpetruc]

now testing in NanoAOD as part of cms-nanoAOD#136

[gpetruc]

+1

• tested for NanoAOD, results look as expected (most jets pass the tight and tight-lepveto id)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1