Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctpps pixel dqm update #22678

Merged
merged 2 commits into from Apr 5, 2018
Merged

ctpps pixel dqm update #22678

merged 2 commits into from Apr 5, 2018

Conversation

popovvp
Copy link
Contributor

@popovvp popovvp commented Mar 20, 2018

2 files modified (to include new station):
plugins/CTPPSPixelDQMSource.cc
python/ctppsPixelDQMSource_cfi.py

@cmsbuild cmsbuild changed the base branch from CMSSW_10_1_X to master March 20, 2018 10:52
@cmsbuild
Copy link
Contributor

@popovvp, CMSSW_10_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @popovvp for master.

It involves the following packages:

DQM/CTPPS

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@popovvp popovvp changed the title ctpps dqm update ctpps pixel dqm update Mar 20, 2018
@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26983/console Started: 2018/03/20 14:21

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2018

Pull request #22678 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27275/console Started: 2018/04/04 18:39

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22678/27275/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2497796
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497619
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 12504.53 KiB( 22 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2018

@dmitrijus @jfernan2 could you please check? I assume this is ok to move forward...

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2018

@popovvp in order to deploy it in operations we will need a backport to 10_1_X, the sooner the PR is available the faster it will be (I understand from @fabferro and V. Avati that this is definitely needed for the RP alignment run in about 10 days from now)

@popovvp
Copy link
Contributor Author

popovvp commented Apr 5, 2018

does it mean I have to open new PR to 10_1_X

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2018

@popovvp yes

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2018

DQM had already approved this PR, and the latest update is transparent (replace an array of 2D histograms with a corresponding array of 1D histograms). As this PR is needed for 10_1_1 I merge it, @dmitrijus @jfernan2 can comment further in case

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2018

merge

@cmsbuild cmsbuild merged commit 66448a2 into cms-sw:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants