New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctpps pixel dqm update #22678
ctpps pixel dqm update #22678
Conversation
@popovvp, CMSSW_10_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22678/4041 |
A new Pull Request was created by @popovvp for master. It involves the following packages: DQM/CTPPS @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison job queued. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22678/4224 |
Pull request #22678 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@dmitrijus @jfernan2 could you please check? I assume this is ok to move forward... |
does it mean I have to open new PR to 10_1_X |
@popovvp yes |
DQM had already approved this PR, and the latest update is transparent (replace an array of 2D histograms with a corresponding array of 1D histograms). As this PR is needed for 10_1_1 I merge it, @dmitrijus @jfernan2 can comment further in case |
+1 |
merge |
2 files modified (to include new station):
plugins/CTPPSPixelDQMSource.cc
python/ctppsPixelDQMSource_cfi.py