Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort GenVisTau collection by their pT in GenVisTauProducer #22684

Merged
merged 1 commit into from Mar 23, 2018

Conversation

ktht
Copy link
Contributor

@ktht ktht commented Mar 20, 2018

Discussion: cms-nanoAOD#118

Backport of #22683 to 94X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2018

A new Pull Request was created by @ktht (Karl Ehatht) for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/HepMCCandAlgos

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@gpetruc
Copy link
Contributor

gpetruc commented Mar 21, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 21, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27020/console Started: 2018/03/21 14:48

@gpetruc
Copy link
Contributor

gpetruc commented Mar 21, 2018

backport of #22683

@gpetruc
Copy link
Contributor

gpetruc commented Mar 21, 2018

+1
we'll need this in the release or AN for the next NanoAOD production.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22684/27020/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2718773
  • DQMHistoTests: Total failures: 102
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2718509
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 9 edm output root files, 26 DQM output files

@arizzi
Copy link
Contributor

arizzi commented Mar 22, 2018

@fabiocos should we move this to be a PR against the AN branch or can it be taken now on the main branch? (we need it anyhow in the AN branch asap)

@cmsbuild cmsbuild removed the backport label Mar 22, 2018
@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e83f2dd into cms-sw:CMSSW_9_4_X Mar 23, 2018
@ktht ktht deleted the genVisTauProducerFix_94x branch April 8, 2018 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants