New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple filter for L3 muons #22714
Simple filter for L3 muons #22714
Conversation
… L2s, it takes a collection of RecoChargedCandidates and produces a TriggerFilterObjectWithRefs, it is capable of applying some cuts on pt, dxy, dz and some id variables
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22714/4083 |
A new Pull Request was created by @folguera (Santiago Folgueras) for master. It involves the following packages: HLTrigger/Muon @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@Martin-Grunewald this is a new class with no configuration attached, so I assume it is at present ineffective, How was it tested? |
the configuration is defined in HLTMuonL3SimplePreFilter::fillDescriptions
… On Mar 23, 2018, at 9:46 AM, Fabio Cossutti ***@***.***> wrote:
@Martin-Grunewald this is a new class with no configuration attached, so I assume it is at present ineffective, How was it tested?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I have privately tested it in one of the single muon paths, giving similar results to current filters. |
@davidlange6 you are right, sorry, I was looking for external configuration fragments but overlooked the internal description |
+1 |
It gets rid of all the mess trying to match to L1 and L2s, it takes a collection of RecoChargedCandidates and produces a TriggerFilterObjectWithRefs, it is capable of applying some cuts on pt, dxy, dz and some id variables