Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force (via bool) simHit matching without CF pointers from digiSimLinks #2285

Merged
merged 1 commit into from Feb 20, 2014

Conversation

wmtford
Copy link
Contributor

@wmtford wmtford commented Feb 4, 2014

Same bug fix as my previous pull request in CMSSW_6_2_X
This change is to restore the hit residuals in relMon that were broken at CMSSW_6_2_0_pre8 as a side effect of the revised tracking particles. A branch in the code that was already in place for pixels is now executed for the strips as well. This branch doesn't depend on the (broken) crossing-frame pointers of the digiSimLinks. Modified files:
SimTracker / TrackerHitAssociation / interface / TrackerHitAssociator.h
SimTracker / TrackerHitAssociation / src / TrackerHitAssociator.cc

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2014

A new Pull Request was created by @wmtford for CMSSW_7_0_X.

Force (via bool) simHit matching without CF pointers from digiSimLinks

It involves the following packages:

SimTracker/TrackerHitAssociation

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@wmtford wmtford mentioned this pull request Feb 4, 2014
@civanch
Copy link
Contributor

civanch commented Feb 4, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf ktf modified the milestones: Next CMSSW_7_0_X release, CMSSW_7_0_0 Feb 16, 2014
@davidlange6
Copy link
Contributor

+1

nclopezo added a commit that referenced this pull request Feb 20, 2014
Force (via bool) simHit matching without CF pointers from digiSimLinks
@nclopezo nclopezo merged commit acbed17 into cms-sw:CMSSW_7_0_X Feb 20, 2014
@wmtford wmtford deleted the hitAssocFix_70X_from_700p12 branch March 10, 2014 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants