Avoid self assignments in SiStrip Key classes #22881
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22881/4263 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DataFormats/SiStripCommon @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 6244927 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-06-1100/src/DataFormats/SiStripCommon/src/SiStripConstants.cc
Entering library rule at RecoEgamma/EgammaHLTProducers
Entering library rule at Utilities/StaticAnalyzers
Entering library rule at src/DataFormats/SiStripCommon/test
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-06-1100/src/DataFormats/SiStripCommon/src/SiStripDetKey.cc: In member function 'virtual void SiStripDetKey::initFromValue()':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-06-1100/src/DataFormats/SiStripCommon/src/SiStripDetKey.cc:209:17: error: comparison is always true due to limited range of data type [-Werror=type-limits]
if(partition_ >=0 and partition_ <=4) {
~~~~~~~~~~~^~~
cc1plus: some warnings being treated as errors
gmake: *** [tmp/slc6_amd64_gcc630/src/DataFormats/SiStripCommon/src/DataFormatsSiStripCommon/SiStripDetKey.cc.o] Error 1
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-06-1100/src/RecoEgamma/EgammaHLTProducers/src/EgammaHLTTimeCleanedRechitProducer.cc
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
When testing for validity of the set values, the logic was changed to avoid doing self assignments. This avoids a clang compiler warning. The changes result in the exact same logic as the original code.
Dr15Jones
force-pushed
the
clangFixSiStripCommon
branch
from
6244927
to
bb87927
Compare
cmsbuild
added
code-checks-pending
comparison-pending
tests-pending
and removed
code-checks-approved
comparison-notrun
tests-rejected
labels
|
The code-checks are being triggered in jenkins. |
|
@gartung FYI |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22881/4264 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
thanks for the cleanup. |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
When testing for validity of the set values, the logic was changed
to avoid doing self assignments. This avoids a clang compiler warning.
The changes result in the exact same logic as the original code.