Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deep flavour of MiniAOD v2 to NANOAOD (master version) #22905

Merged
merged 1 commit into from Apr 9, 2018

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Apr 8, 2018

This adds deepflavour discriminator to nanoaod

same as #22898

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2018

A new Pull Request was created by @arizzi for master.

It involves the following packages:

PhysicsTools/NanoAOD

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Apr 9, 2018

please test workflow 1325.6,1325.8,1325.9

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27386/console Started: 2018/04/09 06:42

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22905/27386/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22905/1325.6_TTbar_13_94Xv1NanoAODINPUT+TTbar_13_94Xv1NanoAODINPUT+NANOAODMC2017_94XMiniAODv1
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22905/1325.8_TTbar_13_94Xv1NanoAODINPUT+TTbar_13_94Xv1NanoAODINPUT+NANOEDMMC2017_94XMiniAODv1+HARVESTNANOAODMC2017_94XMiniAODv1
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22905/1325.9_TTbar_13_92XNanoAODINPUT+TTbar_13_92XNanoAODINPUT+NANOEDMMC2017_92X+HARVESTNANOAODMC2017_92X

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2504254
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2504077
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.22000000009 KiB( 23 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@arizzi
Copy link
Contributor Author

arizzi commented Apr 9, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

Pull request #22905 was updated. @gpetruc, @cmsbuild, @arizzi, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 9, 2018

+1

@cmsbuild cmsbuild merged commit 4381587 into cms-sw:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants