Phase2-hgx107 Change the basic geometry of HGCal from FlatTrd to FlatHexagon #22917

bsunanda · 2018-04-10T13:25:19Z

All cells will be full hexagon and the edge half hexagon may look strange

cmsbuild · 2018-04-10T13:26:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-04-10T13:28:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22917/4306

cmsbuild · 2018-04-10T13:28:29Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CaloGeometry
Geometry/HGCalGeometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2018-04-10T13:29:20Z

@cmsbuild Please test

cmsbuild · 2018-04-10T13:29:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27417/console Started: 2018/04/10 15:30

cmsbuild · 2018-04-10T13:39:28Z

-1

Tested at: 632c33e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22917/27417/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/CondTools/Geometry/plugins/calowriters.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/CondTools/Geometry/plugins/CSCRecoIdealDBLoader.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/CondTools/Geometry/plugins/PGeometricDetBuilder.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/CondTools/Geometry/plugins/ME0RecoIdealDBLoader.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/CondTools/Geometry/plugins/calowriters.cc: In member function 'CaloGeometryDBEP::PtrType CaloGeometryDBEP::produceAligned(const typename T::AlignedRecord&) [with T = HGCalGeometry; U = CaloGeometryDBWriter; CaloGeometryDBEP::PtrType = std::shared_ptr; typename T::AlignedRecord = HGCalGeometryRecord]':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/CondTools/Geometry/plugins/calowriters.cc:406:5: error: 'FlatTrd' has not been declared
     FlatTrd::createCorners( dims, tr, corners );
     ^~~~~~~
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/CondTools/Geometry/plugins/PGeometricDetExtraBuilder.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/CondTools/Geometry/plugins/XMLGeometryReader.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/CondTools/Geometry/plugins/GEMRecoIdealDBLoader.cc

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/Geometry/HGCalGeometry/test/CaloCellGeometryTester.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/Geometry/HGCalGeometry/test/HGCalTestRecHitTool.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/Geometry/HGCalGeometry/test/HGCalGeometryTester.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/Geometry/HGCalGeometry/test/FastTimeGeometryTester.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/Geometry/CaloGeometry/src/FlatHexagon.cc:2:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/Geometry/CaloGeometry/interface/FlatHexagon.h:77:27: error: constexpr variable 'twoBysqrt3_' must be initialized by a constant expression
  static constexpr double twoBysqrt3_ = 2.0/std::sqrt(3.0);
                          ^             ~~~~~~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-04-09-2300/src/Geometry/CaloGeometry/interface/FlatHexagon.h:77:45: note: non-constexpr function 'sqrt' cannot be used in a constant expression
  static constexpr double twoBysqrt3_ = 2.0/std::sqrt(3.0);
                                            ^

cmsbuild · 2018-04-10T13:39:29Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2018-04-11T09:52:48Z

+1
Tested at: 44538b9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22917/27431/summary.html

cmsbuild · 2018-04-11T09:52:50Z

Comparison job queued.

cmsbuild · 2018-04-11T11:42:39Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22917/27431/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 272 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2504590
DQMHistoTests: Total failures: 311
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2504103
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.86999999993 KiB( 21 files compared)
Checked 119 log files, 9 edm output root files, 29 DQM output files

bsunanda · 2018-04-11T13:33:25Z

@ianna @kpedro88 @ggovi Please review and approve this

kpedro88 · 2018-04-11T13:34:33Z

+1

ianna · 2018-04-13T12:23:29Z

+1

fabiocos · 2018-04-14T09:17:24Z

@ggovi could you please check and sign in case?

fabiocos · 2018-04-17T08:04:12Z

@ggovi ping

bsunanda · 2018-04-17T14:15:43Z

@ggovi Please review and approve this

bsunanda · 2018-04-17T14:16:02Z

@fabiocos Please merge this PR

bsunanda · 2018-04-18T13:32:06Z

@fabiocos Fabio please merge this PR. It has no impact on DB. The HGCal geometry does not go to DB yet

ggovi · 2018-04-19T08:42:52Z

+1

cmsbuild · 2018-04-19T08:43:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-04-19T08:50:00Z

+1

Change the basic geometry of HGCal from FlatTrd to FlatHexagon

632c33e

cmsbuild added this to the CMSSW_10_2_X milestone Apr 10, 2018

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Apr 10, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 10, 2018

cmsbuild added tests-started and removed tests-pending labels Apr 10, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Apr 10, 2018

Take care of compilation issues

60aad32

cmsbuild added code-checks-pending comparison-pending and removed code-checks-approved comparison-notrun tests-rejected labels Apr 10, 2018

cmsbuild added the tests-started label Apr 11, 2018

cmsbuild added tests-approved and removed tests-started labels Apr 11, 2018

cmsbuild added comparison-available and removed comparison-pending labels Apr 11, 2018

cmsbuild added upgrade-approved and removed upgrade-pending labels Apr 11, 2018

cmsbuild added geometry-approved and removed geometry-pending labels Apr 13, 2018

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Apr 19, 2018

cmsbuild added orp-approved and removed orp-pending labels Apr 19, 2018

cmsbuild merged commit 2759d59 into cms-sw:master Apr 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx107 Change the basic geometry of HGCal from FlatTrd to FlatHexagon #22917

Phase2-hgx107 Change the basic geometry of HGCal from FlatTrd to FlatHexagon #22917

bsunanda commented Apr 10, 2018

cmsbuild commented Apr 10, 2018

cmsbuild commented Apr 10, 2018

cmsbuild commented Apr 10, 2018

bsunanda commented Apr 10, 2018

cmsbuild commented Apr 10, 2018 •

edited

cmsbuild commented Apr 10, 2018

cmsbuild commented Apr 10, 2018

cmsbuild commented Apr 11, 2018

cmsbuild commented Apr 11, 2018

cmsbuild commented Apr 11, 2018

bsunanda commented Apr 11, 2018

kpedro88 commented Apr 11, 2018

ianna commented Apr 13, 2018

fabiocos commented Apr 14, 2018

fabiocos commented Apr 17, 2018

bsunanda commented Apr 17, 2018

bsunanda commented Apr 17, 2018

bsunanda commented Apr 18, 2018

ggovi commented Apr 19, 2018

cmsbuild commented Apr 19, 2018

fabiocos commented Apr 19, 2018

Phase2-hgx107 Change the basic geometry of HGCal from FlatTrd to FlatHexagon #22917

Phase2-hgx107 Change the basic geometry of HGCal from FlatTrd to FlatHexagon #22917

Conversation

bsunanda commented Apr 10, 2018

cmsbuild commented Apr 10, 2018

cmsbuild commented Apr 10, 2018

cmsbuild commented Apr 10, 2018

bsunanda commented Apr 10, 2018

cmsbuild commented Apr 10, 2018 • edited

cmsbuild commented Apr 10, 2018

cmsbuild commented Apr 10, 2018

cmsbuild commented Apr 11, 2018

cmsbuild commented Apr 11, 2018

cmsbuild commented Apr 11, 2018

bsunanda commented Apr 11, 2018

kpedro88 commented Apr 11, 2018

ianna commented Apr 13, 2018

fabiocos commented Apr 14, 2018

fabiocos commented Apr 17, 2018

bsunanda commented Apr 17, 2018

bsunanda commented Apr 17, 2018

bsunanda commented Apr 18, 2018

ggovi commented Apr 19, 2018

cmsbuild commented Apr 19, 2018

fabiocos commented Apr 19, 2018

cmsbuild commented Apr 10, 2018 •

edited