Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the DB schema explicitly in the SiStrip O2O code #23009

Merged
merged 1 commit into from Apr 23, 2018

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Apr 19, 2018

No description provided.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hqucms for master.

It involves the following packages:

OnlineDB/SiStripO2O

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@erikbutz, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@fabiocos
Copy link
Contributor

@ggovi please check this PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27609/console Started: 2018/04/23 14:13

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ggovi
Copy link
Contributor

ggovi commented Apr 23, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor

mmusich commented Apr 23, 2018

Hi @hqucms
for my understanding is this related to the password expiration issue logged here?

@hqucms
Copy link
Contributor Author

hqucms commented Apr 23, 2018

Hi @mmusich
Yes. This is to allow the O2O to read hash map table via CMS_COND_GENERAL_R so we no longer rely on the owner account (CMS_COND_O2O) directly.

@mmusich
Copy link
Contributor

mmusich commented Apr 23, 2018

@hqucms thanks!

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23009/27609/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2492830
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2492653
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit baa75df into cms-sw:master Apr 23, 2018
@hqucms hqucms deleted the sistrip-o2o-fix-schema branch November 15, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants