Run2-alca127 Change calibration code for HB/HE using muons #23013
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23013/4411 |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Calibration/HcalCalibAlgos @cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: fc18d5d You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@cmsbuild Please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
Did not understand which add on test give this failure. Please advise |
|
Sunanda, I believe it's fastsim2 test failure (unrelated to your PR)
which is supposed to be fixed in
#23019
…On Fri, 20 Apr 2018, bsunanda wrote:
Did not understand which add on test give this failure. Please advise
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.[AEx02rdNlOQ-1mkv6B1Og9NYtlJMnBBQks5tqdi2gaJpZM4TcJD5.gif]
|
|
... well, I was too fast...
In this case it's fastsim1 (something enigmatic at the end of log file):
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23013/27578/addOnTests/fastsim1/cmsDriver.py_TTbar_13TeV_TuneCUETP8M1_cfi_--conditions_auto:run2_mc_l1stage1_--fast__-n_100_--eventcontent_AODSIM,DQM_--relval_100000,1000_-s_GEN,SIM,.log
…On Fri, 20 Apr 2018, Salavat Abdoulline wrote:
Sunanda, I believe it's fastsim2 test failure (unrelated to your PR) which
is supposed to be fixed in
https: //github.com/cms-sw/cmssw/pull/23019
On Fri, 20 Apr 2018, bsunanda wrote:
>
> Did not understand which add on test give this failure. Please advise
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the
> thread.[AEx02rdNlOQ-1mkv6B1Og9NYtlJMnBBQks5tqdi2gaJpZM4TcJD5.gif]
>
>
>
|
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Add a few more variables for calibration