Specify upgrade digi collections for HCAL TP emulation in offline DQM

[christopheralanwest]

The HCAL offline DQM runs on the HcalNZS stream, which contains events for which no zero suppression is applied to the HCAL raw data; such events are needed for validating the HCAL trigger primitive (TP) generation. This PR corrects the behavior of the TP emulation in the HCAL offline DQM. Currently the InputTags for digis in the upgraded portion of the HCAL (HE and HF) are not specified. This results in all of the emulated TPs being set to zero (table below, left column). After the change (right column), the emulated TPs are nonzero and good agreement is seen between data and emulated TPs. The setup for the tests can be found below [1], where in the "after" case this PR is merged as well.

Subdetector	Before changes	After changes
HBHE	ETCorr_HBHE_beforefix.pdf	ETCorr_HBHE_afterfix.pdf
HF	ETCorr_HF_beforefix.pdf	ETCorr_HF_afterfix.pdf

[1]

cmsrel CMSSW_10_2_0_pre1
cd CMSSW_10_2_0_pre1/src
cmsenv
git cms-addpkg Configuration/DataProcessing
scram b -j4
python $CMSSW_BASE/src/Configuration/DataProcessing/test/RunPromptReco.py --scenario hcalnzsEra_Run2_2018 --dqmSeq @common+@hcal --reco --dqmio --global-tag 101X_dataRun2_Prompt_v9 --lfn=file:/eos/cms/store/data/Commissioning2018/HcalNZS/RAW/v1/000/314/473/00000/5C2FF0C0-3742-E811-810B-FA163ED9F81E.root
cmsRun -e RunPromptRecoCfg.py
DQMIO2histo.py -in output_inDQMIO.root -o histos.root

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23039/4439

[cmsbuild]

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

L1Trigger/Configuration

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27617/console Started: 2018/04/23 18:16

[cmsbuild]

+1
Tested at: 0892139
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23039/27617/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23039/27617/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2492830
• DQMHistoTests: Total failures: 30
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2492624
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@christopheralanwest I see that the changes in DQM are concentrated only in one wf 136.788 . For my understanding is this expected and why?

[christopheralanwest]

@fabiocos Yes, the concentration in wf 136.788 is expected. The emulated trigger primitives are used to compare the trigger primitives generated by the hardware with the software emulation in order to check the consistency of the hardware HCAL trigger primitive generation. This is not a meaningful check in MC as there is no "hardware" in MC, only the software emulation, and therefore this check is not performed. The re-emulation is performed using the RAW and so only workflows that run on RAW could be affected. Finally, prior to the HCAL upgrades in 2017, the upgrade digi collections were not used and so the InputTags for the upgrade digi collections are ignored. The only workflow that matches all of these criteria is 136.788.

[fabiocos]

@christopheralanwest thanks

[fabiocos]

+1