Timing hgcal realistic sim pf #23047
Conversation
Cluster3DPCACalculator internally has been coded such that it also computes timing information for the hits associated to the passed clusters. Unfortunately this procedure was overwriting the newly implemented method to compute timing for HGCAL clusters. HGCAL seems to be the only left customer of this code. A flag has been added to disable the assignment of timing to the cluster, not to disable the timing computation. We are still in the process of defining where and how to properly associate a timing to (which) cluster, so this solution can be considered as temporary.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23047/4449 |
|
A new Pull Request was created by @rovere (Marco Rovere) for master. It involves the following packages: RecoParticleFlow/PFClusterProducer @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
FYI @amartelli @malgeri |
|
@rovere |
|
@amartelli is on leave up to next week and I'm not sure if/when she will find the time to integrate my PR to her repo. |
OK. |
|
assign upgrade |
|
New categories assigned: upgrade @kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
@slava77 |
|
please test |
|
The tests are being triggered in jenkins. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23047/4577 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
+1 |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Introduce timing for realistic sim clusters, in HGCAL only.
Use algorithm optimized for TDR studies.
N.B. time is referred to the start of the BX, it is corrected for tof in the hypothesis of neutral and light particle: for longer track length and beta < 1 need offset correction at the analysis level
The timing for the hits in HGCAL is enabled in the PR #21957
Please refer to #22758 for the original PR and discussion therein.
#22758 can be closed.