Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of HLT menu (101X) #23079

Closed
wants to merge 4 commits into from

Conversation

silviodonato
Copy link
Contributor

101X backport of #23077

@silviodonato
Copy link
Contributor Author

hold

@cmsbuild cmsbuild added this to the CMSSW_10_1_X milestone Apr 27, 2018
@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @silviodonato
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_10_1_X.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @geoff-smith this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

Pull request #23079 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

@arunhep
Copy link
Contributor

arunhep commented May 9, 2018

@silviodonato @Martin-Grunewald
there you go : ac031c6

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

Pull request #23079 was updated. @cmsbuild, @silviodonato, @arunhep, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @lpernie can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

Great, thanks!

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27881/console Started: 2018/05/09 15:35

@silviodonato
Copy link
Contributor Author

unhold

@cmsbuild cmsbuild removed the hold label May 9, 2018
@Martin-Grunewald
Copy link
Contributor

Rebased to 10_1_4

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23079/27881/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2507432
  • DQMHistoTests: Total failures: 2246
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 2505002
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 22.197 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 10824.0 ): -492.157 KiB HLT/BPH
  • DQMHistoSizes: changed ( 10824.0 ): 289.928 KiB HLT/JME
  • DQMHistoSizes: changed ( 10824.0 ): 124.477 KiB HLT/EGM
  • DQMHistoSizes: changed ( 10824.0 ): 108.571 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 10824.0 ): 49.520 KiB HLT/Exotica
  • DQMHistoSizes: changed ( 10824.0 ): -34.989 KiB HLT/Objects
  • DQMHistoSizes: changed ( 10824.0 ): -26.469 KiB HLT/Higgs
  • DQMHistoSizes: changed ( 10824.0 ): 2.896 KiB HLT/GeneralHLTOffline
  • DQMHistoSizes: changed ( 10824.0 ): 0.391 KiB HLT/Muon
  • DQMHistoSizes: changed ( 10824.0 ): 0.031 KiB HLT/BTV
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@arunhep
Copy link
Contributor

arunhep commented May 10, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@Martin-Grunewald
Copy link
Contributor

Superseded by #23293

@Martin-Grunewald
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @Martin-Grunewald
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@Martin-Grunewald
Copy link
Contributor

close

@Martin-Grunewald
Copy link
Contributor

@silviodonato
Can you please close this PR as being superseeded?
Thanks!

@Martin-Grunewald Martin-Grunewald deleted the HLT_v2_101X branch November 17, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants