Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module for selecting tracks matched to a muon #23110

Merged
merged 2 commits into from May 3, 2018

Conversation

KyeongPil-Lee
Copy link
Contributor

This PR adds a new module to select tracks only matched to a muon in HLT.
In current HLT menu, PF uses the tracks produced in L3 muon reconstruction sequence before applying ID, which could increase the rate of PF-related triggers (e.g. MET triggers).
Instead of feeding the tracks before ID, the output of this module (the "clean" tracks matched to a muon after ID) can be fed to PF modules so that the rate of triggers using PF can be stable.
Backport to 10_1_X is also needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23110/4529

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23110/4529/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23110/4529/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

A new Pull Request was created by @KyeongPil-Lee for master.

It involves the following packages:

HLTrigger/Muon

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @Martin-Grunewald, @calderona, @HuguesBrun, @drkovalskyi, @trocino, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27751/console Started: 2018/05/02 15:31

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23110/27751/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23110/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2721257
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721073
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 3, 2018

@Martin-Grunewald this new module is not run in basic tests here, I assume it was tested offline by the HLT group, am I correct?

@Martin-Grunewald
Copy link
Contributor

@fabiocos
Indeed, the author reported that no problem was found in quick tests (No crashes, # passing events for a MET trigger reduced).

@fabiocos
Copy link
Contributor

fabiocos commented May 3, 2018

+1

@cmsbuild cmsbuild merged commit a615bcf into cms-sw:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants