Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T DQM timing plot upgrades part2 #23128

Merged

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented May 3, 2018

Split the uGT DQM module in one that handles the standard DQM plots and another one for the timing plots.
This way the timing plot module can run also in the offline DQM while the other module does not run because of the large 2D histograms.

Also moves the calo L2 output to uGT input comparison configuration to the uGT configuration.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQM/L1TMonitor
DQM/L1TMonitorClient

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@kreczko this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

thomreis commented May 3, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27772/console Started: 2018/05/03 16:06

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23128/27772/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2720589
  • DQMHistoTests: Total failures: 2314
  • DQMHistoTests: Total nulls: 62
  • DQMHistoTests: Total successes: 2718030
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4528.609 KiB( 29 files compared)
  • DQMHistoSizes: changed ( 136.731,... ): 208.208 KiB L1T/L1TObjects
  • DQMHistoSizes: changed ( 136.731,... ): 145.472 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 10824.0,... ): 211.191 KiB L1T/L1TObjects
  • DQMHistoSizes: changed ( 10824.0,... ): 145.996 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 10042.0,... ): 145.668 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 25202.0,... ): 177.987 KiB L1T/L1TObjects
  • DQMHistoSizes: changed ( 25202.0,... ): 143.699 KiB L1T/L1TStage2uGT
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27821/console Started: 2018/05/05 22:18

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23128/27821/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2713580
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2713396
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1888.697 KiB( 29 files compared)
  • DQMHistoSizes: changed ( 11624.0,... ): 145.996 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 136.731,... ): 145.472 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 10224.0,... ): 145.668 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 25202.0,... ): 143.699 KiB L1T/L1TStage2uGT
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented May 8, 2018

+1

@cmsbuild cmsbuild merged commit 3d5c746 into cms-sw:master May 8, 2018
@thomreis thomreis deleted the l1t_dqm_timing_plot_upgrades_part2_102x branch August 20, 2018 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants