Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of dtTriggerSyncTask configuration #23144

Merged
merged 1 commit into from May 5, 2018

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented May 4, 2018

Fix of the configuration problem reported in https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/1875/1/1.html introduced in #23071 (and #23072 for 101X). See #23072 (review)

Tested (in CMSSW_10_1_3) using Configuration/DataProcessing:

python RunExpressProcessing.py --scenario ppEra_Run2_2018 --lfn /store/t0streamer/Data/Express/000/315/322/run315322_ls1364_streamExpress_StorageManager.dat --global-tag 101X_dataRun2_Express_v7 --fevt --dqmio --alcarecos=DtCalib

manually modifying the output configuration

process.maxEvents = cms.untracked.PSet(
input = cms.untracked.int32(-1)
)
process.source = cms.Source("NewEventStreamFileReader",
fileNames = cms.untracked.vstring('/store/t0streamer/Data/Express/000/315/322/run315322_ls1364_streamExpress_StorageManager.dat')
)
process.options = cms.untracked.PSet(
numberOfStreams = cms.untracked.uint32(0),
numberOfThreads = cms.untracked.uint32(8)
)

to get the correct source. The file is processed correctly and the ALCARECO output file is produced. The produced output configuration is:

process.dtTriggerSynchMonitor = cms.EDProducer("DTLocalTriggerSynchTask",
DDUInputTag = cms.InputTag("muonDTDigis"),
SEGInputTag = cms.InputTag("dt4DSegmentsNoWire"),
TMInputTag = cms.InputTag("dttfDigis"),
angleRange = cms.double(30.0),
baseDir = cms.string('AlCaReco/DtCalibSynch/02-Synchronization'),
bxTimeInterval = cms.double(25),
minHitsPhi = cms.int32(7),
nBXHigh = cms.int32(3),
nBXLow = cms.int32(-2),
processDDU = cms.untracked.bool(False),
rangeWithinBX = cms.bool(False),
staticBooking = cms.untracked.bool(True),
tTrigMode = cms.string('DTTTrigSyncFromDB'),
tTrigModeConfig = cms.PSet(
debug = cms.untracked.bool(False),
doT0Correction = cms.bool(False),
doTOFCorrection = cms.bool(False),
doWirePropCorrection = cms.bool(False),
tTrigLabel = cms.string(''),
tofCorrType = cms.int32(0),
vPropWire = cms.double(24.4),
wirePropCorrType = cms.int32(0)
)
)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

DQM/DTMonitorModule

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented May 4, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27796/console Started: 2018/05/04 14:32

@fabiocos
Copy link
Contributor Author

fabiocos commented May 4, 2018

@battibass FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23144/27796/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2713580
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2713396
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@fabiocos
Copy link
Contributor Author

fabiocos commented May 5, 2018

+1

@fabiocos
Copy link
Contributor Author

fabiocos commented May 5, 2018

merge

@cmsbuild cmsbuild merged commit 03f411c into cms-sw:master May 5, 2018
@fabiocos fabiocos deleted the fc-fixDtCalib branch May 9, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants