Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of ttHfgenfilter to 94X #23167

Merged
merged 1 commit into from
May 15, 2018

Conversation

Andrej-CMS
Copy link
Contributor

Dear all,

this is a backport of #21743 to CMSSW 94X. To make the tagging functionality being available in this release.

Kind regards,
Andrej

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2018

A new Pull Request was created by @Andrej-CMS for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/JetMCAlgos

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Andrej-CMS
Copy link
Contributor Author

Dear @ALL,
Please have a look at the PR and let me know if there are any issues with it! It would be very nice to have this in the next CMSSW 94X release.

Kind regards,

Andrej

@kpedro88
Copy link
Contributor

please test

@kpedro88
Copy link
Contributor

backport of #21743

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27959/console Started: 2018/05/15 17:07

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23167/27959/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 109
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721222
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@fabiocos
Copy link
Contributor

+1

code already merged in master since months, the test configuration provided runs smoothly

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 928b9bc into cms-sw:CMSSW_9_4_X May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants