Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix headers in EventFilter pkgs #23176

Closed
wants to merge 1 commit into from
Closed

fix headers in EventFilter pkgs #23176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions EventFilter/GEMRawToDigi/interface/VFATdata.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#ifndef EventFilter_GEMRawToDigi_VFATdata_h
#define EventFilter_GEMRawToDigi_VFATdata_h
#include "stdint.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

system includes are typically in the brackets <stdint.h>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed here #23189. I'd separate this pr into pieces


namespace gem {
class VFATdata
Expand Down
2 changes: 2 additions & 0 deletions EventFilter/L1TRawToDigi/interface/PackerTokens.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#ifndef EventFilter_L1TRawToDigi_PackerTokens_h
#define EventFilter_L1TRawToDigi_PackerTokens_h

#include "FWCore/Utilities/interface/EDGetToken.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not look right.


namespace edm {
class ConsumesCollector;
class ParameterSet;
Expand Down
1 change: 1 addition & 0 deletions EventFilter/L1TRawToDigi/plugins/implementations_stage2/CaloLayer1Tokens.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include "DataFormats/EcalDigi/interface/EcalDigiCollections.h"
#include "DataFormats/HcalDigi/interface/HcalDigiCollections.h"
#include "DataFormats/L1CaloTrigger/interface/L1CaloCollections.h"
#include "FWCore/Utilities/interface/EDGetToken.h"
#include "EventFilter/L1TRawToDigi/interface/PackerTokens.h"

namespace l1t {
Expand Down
2 changes: 1 addition & 1 deletion EventFilter/L1TRawToDigi/plugins/implementations_stage2/CommonTokens.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include "DataFormats/L1Trigger/interface/Jet.h"
#include "DataFormats/L1Trigger/interface/Tau.h"
#include "DataFormats/L1Trigger/interface/Muon.h"

#include "FWCore/Utilities/interface/EDGetToken.h"
#include "EventFilter/L1TRawToDigi/interface/PackerTokens.h"

namespace l1t {
Expand Down
2 changes: 2 additions & 0 deletions EventFilter/L1TRawToDigi/plugins/implementations_stage2/IntermediateMuonUnpacker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#ifndef EventFilter_L1TRawToDigi_stage2_IntermediateMuonUnpacker_h
#define EventFilter_L1TRawToDigi_stage2_IntermediateMuonUnpacker_h

#include <map>
#include "DataFormats/L1Trigger/interface/Muon.h"
#include "EventFilter/L1TRawToDigi/interface/Unpacker.h"

namespace l1t {
Expand Down
1 change: 1 addition & 0 deletions EventFilter/L1TRawToDigi/plugins/implementations_stage2/MuonPacker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#ifndef L1T_PACKER_STAGE2_MUONPACKER_H
#define L1T_PACKER_STAGE2_MUONPACKER_H

#include <map>
#include "EventFilter/L1TRawToDigi/interface/Packer.h"

namespace l1t {
Expand Down
7 changes: 7 additions & 0 deletions EventFilter/L1TRawToDigi/plugins/implementations_stage2/RegionalMuonGMTPacker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
#ifndef L1T_PACKER_STAGE2_REGIONALMUONGMTPACKER_H
#define L1T_PACKER_STAGE2_REGIONALMUONGMTPACKER_H

#include <vector>
#include <map>
#include "FWCore/Framework/interface/Event.h"
#include "DataFormats/L1TMuon/interface/RegionalMuonCand.h"
#include "EventFilter/L1TRawToDigi/interface/Block.h"
#include "EventFilter/L1TRawToDigi/interface/PackerTokens.h"

namespace l1t {
namespace stage2 {
class RegionalMuonGMTPacker : public Packer {
Expand Down
4 changes: 2 additions & 2 deletions EventFilter/Phase2TrackerRawToDigi/interface/Phase2TrackerFEDChannel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@

#include "EventFilter/Phase2TrackerRawToDigi/interface/Phase2TrackerFEDDAQHeader.h"
#include "EventFilter/Phase2TrackerRawToDigi/interface/Phase2TrackerFEDDAQTrailer.h"
#include "EventFilter/Phase2TrackerRawToDigi/interface/Phase2TrackerFEDBuffer.h"
#include <cstdint>

namespace Phase2Tracker {

//forward declaration
class Phase2TrackerFEDBuffer;
// holds information about position of a channel in the buffer
// for use by unpacker
class Phase2TrackerFEDChannel
Expand Down