Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[102X][Change GTs] 2016,2017 JES and JER #23212

Merged
merged 4 commits into from May 22, 2018
Merged

Conversation

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@lpernie
Copy link
Contributor Author

lpernie commented May 16, 2018

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27968/console Started: 2018/05/16 02:28

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lpernie (Luca Pernie) for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23212/27968/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 160 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2715235
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2715033
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@lpernie
Copy link
Contributor Author

lpernie commented May 21, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

please test

now the code that is expected to fix the reproducibility of tests has been merged, try again

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28097/console Started: 2018/05/22 09:02

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23212/28097/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 985 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2901712
  • DQMHistoTests: Total failures: 4279
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2897243
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

@lpernie @arunhep are the changes to Run1 test workflows expected? The PR is referring to 2016 and 2017 samples...

@lpernie
Copy link
Contributor Author

lpernie commented May 22, 2018

Hello @fabiocos ,
I discussed with Sangeun.
The previous TAGs were single IOV TAGs with a payload describing 2017 data, and they were starting from RUN=1.
The new TAGs include 3 IOV for 2016 and 1 IOV for 2017. Also in this case they to start from RUN=1, so changes in the RUN1 workflow are observed.

@fabiocos
Copy link
Contributor

@lpernie thanks for the clarification, my question is: is this the behaviour that we want? I understand that the Run1 legacy release cycle is 53X, but...

@lpernie
Copy link
Contributor Author

lpernie commented May 22, 2018

Hi @fabiocos ,
I cannot imagine an better solution. Maybe that these TAGs could start not from RUN=1 but from the first RUN in 2016, but is something we prefer to avoid as a general rule.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5cd2797 into cms-sw:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants