Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few gcc 4.9.0 issues #2322

Merged
merged 1 commit into from Feb 11, 2014
Merged

Fix a few gcc 4.9.0 issues #2322

merged 1 commit into from Feb 11, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Feb 6, 2014

No description provided.

@ktf ktf closed this Feb 6, 2014
@ktf ktf reopened this Feb 6, 2014
@ktf
Copy link
Contributor Author

ktf commented Feb 6, 2014

This should fix a good fraction of the remaining gcc 4.9.0 errors. Notice that one of the problems seems to be related to a "regression" in gcc 4.9.0. If I understand correctly the problem is that it adheres better to the standard, but the standard specification itself might be buggy. Not sure how we want to proceed there.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2014

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Fix a few gcc 4.9.0 issues

It involves the following packages:

CondCore/CondDB
FWCore/Framework
FWCore/Services

@apfeiffer1, @Dr15Jones, @cmsbuild, @nclopezo, @ggovi, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2014

-1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopKinFitter had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestTqafExamples had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2322/49/summary.html

@ktf
Copy link
Contributor Author

ktf commented Feb 6, 2014

das glitch, I guess...

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

@apfeiffer1
Copy link
Contributor

+1

@ktf
Copy link
Contributor Author

ktf commented Feb 11, 2014

+1
Chris I assume from our discussions last week you do not object?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Feb 11, 2014
Gcc 4.9.0 -- Fix a few gcc 4.9.0 issues
@ktf ktf merged commit c939831 into cms-sw:CMSSW_7_1_X Feb 11, 2014
@ktf ktf deleted the fix-490-take2 branch February 11, 2014 23:27
@Dr15Jones
Copy link
Contributor

It was fine with me.

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants