Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to CalibFormats/SiPixelObjects to fix gcc 8 compiler errors #23233

Merged
merged 2 commits into from
May 22, 2018
Merged

Changes to CalibFormats/SiPixelObjects to fix gcc 8 compiler errors #23233

merged 2 commits into from
May 22, 2018

Commits on May 17, 2018

  1. Removed unnecesary try catch of std::bad_cast 

    Only a std::dynamic_cast of a reference throws std:bad_cast. This
code does not do that.
    @Dr15Jones
    Dr15Jones committed May 17, 2018
    Configuration menu
    Copy the full SHA
    9a0c225 View commit details
    Browse the repository at this point in the history

  2. Fixed calls to sprintf to avoid buffer problems. 

    Switched from sprintf to snprintf and set buffer size to maximum
possible size to avoid truncations.
This was required by gcc 8.
    @Dr15Jones
    Dr15Jones committed May 17, 2018
    Configuration menu
    Copy the full SHA
    8fc583d View commit details
    Browse the repository at this point in the history