[GCC 8] [RECO] Fixed const correctness for operator() #23246

smuzaffar · 2018-05-18T12:52:34Z

No description provided.

cmsbuild · 2018-05-18T12:52:51Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-05-18T12:55:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23246/4723

smuzaffar · 2018-05-18T12:55:24Z

please test

cmsbuild · 2018-05-18T12:55:26Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28040/console Started: 2018/05/18 14:57

cmsbuild · 2018-05-18T12:55:28Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DataFormats/METReco
DataFormats/MuonData
EventFilter/EcalTBRawToDigi
RecoMET/METAlgorithms
RecoVertex/MultiVertexFit

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jdamgov, @TaiSakuma, @gouskos, @ebrondol, @jdolen, @makortel, @felicepantaleo, @rappoccio, @GiacomoSguazzoni, @mmarionncern, @rovere, @VinInn, @Martin-Grunewald, @ahinzmann, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @argiro, @dgulhan, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2018-05-18T15:51:35Z

+1
Tested at: aa0361c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23246/28040/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
58fdc16
6bdf89e
4ce5809
95ec6b8
8d539d4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23246/28040/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23246/28040/git-merge-result

cmsbuild · 2018-05-18T15:51:38Z

Comparison job queued.

cmsbuild · 2018-05-18T18:03:17Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23246/28040/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23246/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 28 differences found in the comparisons
DQMHistoTests: Total files compared: 30
DQMHistoTests: Total histograms compared: 2740553
DQMHistoTests: Total failures: 7639
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2732731
DQMHistoTests: Total skipped: 183
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
Checked 124 log files, 14 edm output root files, 30 DQM output files

Dr15Jones · 2018-05-18T18:49:04Z

DataFormats/METReco/interface/HcalNoiseRBX.h

@@ -97,7 +97,7 @@ namespace reco {

    // helper function to get the unique calotowers
    struct twrcomp {
-      inline bool operator() ( const CaloTower & t1, const CaloTower & t2 ) {
+      inline bool operator() ( const CaloTower & t1, const CaloTower & t2 ) const{


This overlaps with #23235

Dr15Jones · 2018-05-18T18:50:02Z

RecoVertex/MultiVertexFit/interface/LinTrackCache.h

@@ -12,12 +12,12 @@ class LinTrackCache
 private:
  struct Comparer
  {
-    bool operator() ( const GlobalPoint &, const GlobalPoint & );


This overlaps with #23237

perrotta · 2018-05-19T07:15:21Z

please test
(to get rid of the effect of the extra commits on jenkins outputs)

cmsbuild · 2018-05-21T01:56:46Z

The code-checks are being triggered in jenkins.

smuzaffar · 2018-05-21T01:56:54Z

please test

cmsbuild · 2018-05-21T02:00:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23246/4754

cmsbuild · 2018-05-21T02:00:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28072/console Started: 2018/05/21 04:55

cmsbuild · 2018-05-21T02:00:37Z

Pull request #23246 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

cmsbuild · 2018-05-21T05:45:24Z

+1
Tested at: 0c6e440
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23246/28072/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0c6e440
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23246/28072/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23246/28072/git-merge-result

cmsbuild · 2018-05-21T05:45:27Z

Comparison job queued.

cmsbuild · 2018-05-21T07:42:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23246/28072/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2901712
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2901520
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

perrotta · 2018-05-21T08:04:23Z

+1

Technical
Jenkins tests pass with no differences

cmsbuild · 2018-05-21T08:06:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-05-21T08:11:59Z

+1

Fixed const correctness for operator()

aa0361c

cmsbuild added this to the CMSSW_10_2_X milestone May 18, 2018

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 18, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels May 18, 2018

cmsbuild added tests-started and removed tests-pending labels May 18, 2018

smuzaffar changed the title ~~[GCC 8] Fixed const correctness for operator()~~ [GCC 8] [RECO] Fixed const correctness for operator() May 18, 2018

cmsbuild added tests-approved and removed tests-started labels May 18, 2018

cmsbuild added comparison-available and removed comparison-pending labels May 18, 2018

Dr15Jones reviewed May 18, 2018

View reviewed changes

cmsbuild removed comparison-available tests-approved labels May 19, 2018

cmsbuild added code-checks-pending comparison-pending reconstruction-pending tests-pending labels May 21, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels May 21, 2018

cmsbuild added tests-started and removed tests-pending labels May 21, 2018

cmsbuild added tests-approved and removed tests-started labels May 21, 2018

cmsbuild added comparison-available and removed comparison-pending labels May 21, 2018

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels May 21, 2018

cmsbuild added orp-approved and removed orp-pending labels May 21, 2018

cmsbuild merged commit 147c203 into cms-sw:master May 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GCC 8] [RECO] Fixed const correctness for operator() #23246

[GCC 8] [RECO] Fixed const correctness for operator() #23246

smuzaffar commented May 18, 2018

cmsbuild commented May 18, 2018

cmsbuild commented May 18, 2018

smuzaffar commented May 18, 2018

cmsbuild commented May 18, 2018 •

edited

cmsbuild commented May 18, 2018

cmsbuild commented May 18, 2018

cmsbuild commented May 18, 2018

cmsbuild commented May 18, 2018

Dr15Jones May 18, 2018

Dr15Jones May 18, 2018

perrotta commented May 19, 2018

cmsbuild commented May 21, 2018

smuzaffar commented May 21, 2018

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018 •

edited

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

perrotta commented May 21, 2018

cmsbuild commented May 21, 2018

fabiocos commented May 21, 2018

[GCC 8] [RECO] Fixed const correctness for operator() #23246

[GCC 8] [RECO] Fixed const correctness for operator() #23246

Conversation

smuzaffar commented May 18, 2018

cmsbuild commented May 18, 2018

cmsbuild commented May 18, 2018

smuzaffar commented May 18, 2018

cmsbuild commented May 18, 2018 • edited

cmsbuild commented May 18, 2018

cmsbuild commented May 18, 2018

cmsbuild commented May 18, 2018

cmsbuild commented May 18, 2018

Dr15Jones May 18, 2018

Choose a reason for hiding this comment

Dr15Jones May 18, 2018

Choose a reason for hiding this comment

perrotta commented May 19, 2018

cmsbuild commented May 21, 2018

smuzaffar commented May 21, 2018

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018 • edited

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

perrotta commented May 21, 2018

cmsbuild commented May 21, 2018

fabiocos commented May 21, 2018

cmsbuild commented May 18, 2018 •

edited

cmsbuild commented May 21, 2018 •

edited