[L1T][DQMOffline] Fixes for L1T jet DQMOffline #23269

kreczko · 2018-05-21T14:24:21Z

Partly fixes https://its.cern.ch/jira/projects/CMSLITDPG/issues/CMSLITDPG-588

Drop “events” y axis label for efficiency plots.
Phi resolution plots should not show (phi-phi_offline)/phi_offline but phi-phi_offline only.
Eta resolution plots should not show (eta-eta_offline)/eta_offline but eta-eta_offline only.
fill the efficiencies even if no a matched jet is found.
currentDeltaR > minDeltaR→ currentDeltaR >= minDeltaR

…f no matched L1 jet is found

cmsbuild · 2018-05-21T14:24:39Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-05-21T14:26:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23269/4762

cmsbuild · 2018-05-21T14:26:59Z

A new Pull Request was created by @kreczko (Luke Kreczko) for master.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks.
@thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2018-05-21T14:45:26Z

please test

cmsbuild · 2018-05-21T14:45:43Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28086/console Started: 2018/05/21 16:48

cmsbuild · 2018-05-21T16:16:25Z

+1
Tested at: 21a416b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23269/28086/summary.html

cmsbuild · 2018-05-21T16:16:27Z

Comparison job queued.

cmsbuild · 2018-05-21T17:21:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23269/28086/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2901712
DQMHistoTests: Total failures: 2247
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2899275
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

thomreis · 2018-05-22T09:25:24Z

DQMOffline/L1Trigger/src/L1TStage2CaloLayer2Offline.cc

-  double resolutionEta = std::abs(recoEta) > 0 ? (l1Eta - recoEta) / recoEta : outOfBounds;
-  double resolutionPhi = std::abs(recoPhi) > 0 ? (l1Phi - recoPhi) / recoPhi : outOfBounds;
+  double resolutionEta = l1Eta - recoEta;
+  double resolutionPhi = l1Phi - recoPhi;


This delta needs to wrap around at pi. The delta cannot be larger than pi since then they are back to back.

Will change to reco::deltaPhi(l1Phi, recoPhi)

BTW: This will give you sensible values if no matched jet was found, shall I do
l1Phi < 9999 ? reco::deltaPhi(l1Phi, recoPhi) : 9999 instead?

But then you would not fill the histogram if no match is found. So I guess it does not matter in the end. It would be cleaner though.

Yes, you are right. I will add outOfBounds just in case someone in the future decides to still fill the plots ;). Otherwise it is an easy to overlook bug with reco::deltaPhi.

thomreis · 2018-05-22T09:32:04Z

DQMOffline/L1Trigger/src/L1TStage2CaloLayer2Offline.cc

+  if (!foundMatch){
+    return;
+  }
+
  // eta
  fill2DWithinLimits(h_L1JetEtavsCaloJetEta_, recoEta, l1Eta);
  fillWithinLimits(h_resolutionJetEta_, resolutionEta);


The offline control plots could be filled even if there is no matching offline object found.

Control plots as in h_controlPlots_ or also h_L1JetEtavsCaloJetEta_, h_resolutionJetEta_, etc?

Everything that does not need L1 objects. I think that's only fillWithinLimits(h_controlPlots_[ControlPlots::OfflineJetET], recoEt);

…ven if no L1Jet is matched

cmsbuild · 2018-05-22T10:53:19Z

Pull request #23269 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please check and sign again.

thomreis · 2018-05-22T12:32:09Z

please test

cmsbuild · 2018-05-22T12:32:26Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28105/console Started: 2018/05/22 16:37

thomreis · 2018-05-22T12:33:27Z

Hi @kreczko
do you plan to add the additional Jets and sums improvements to this PR or will you make a new one?

kreczko · 2018-05-22T12:50:07Z

@thomreis I will make a new one since it is easier to review shorter PRs ;).
Thanks for the feedback btw

thomreis · 2018-05-22T12:56:24Z

+1

thomreis · 2018-05-22T12:58:20Z

@kreczko we will also need a 101x backport PR for this one so that it can be deployed at the T0.

dmitrijus · 2018-05-22T13:36:11Z

+1

cmsbuild · 2018-05-22T13:36:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2018-05-22T17:22:11Z

+1
Tested at: 10ef4b4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23269/28105/summary.html

cmsbuild · 2018-05-22T17:22:14Z

Comparison job queued.

cmsbuild · 2018-05-22T19:29:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23269/28105/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2901712
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2901520
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

fabiocos · 2018-05-24T07:44:00Z

+1

kreczko added 4 commits May 21, 2018 09:55

dropped "events" y axis label for efficiency plots

0e9fc55

phi & eta resolution no longer divides by reco quantity

ccfd7df

changed "currentDeltaR > minDeltaR" to "currentDeltaR >= minDeltaR"

52e0fe7

moved filling jet efficiencies into separate function and fill even i…

21a416b

…f no matched L1 jet is found

cmsbuild added this to the CMSSW_10_2_X milestone May 21, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels May 21, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels May 21, 2018

cmsbuild added tests-started and removed tests-pending labels May 21, 2018

cmsbuild added tests-approved and removed tests-started labels May 21, 2018

cmsbuild added comparison-available and removed comparison-pending labels May 21, 2018

thomreis reviewed May 22, 2018

View reviewed changes

resolutionPhi now using reco::deltaPhi and control plots are filled e…

10ef4b4

…ven if no L1Jet is matched

cmsbuild added the code-checks-approved label May 22, 2018

cmsbuild added tests-started and removed tests-pending labels May 22, 2018

cmsbuild added l1-approved and removed l1-pending labels May 22, 2018

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 22, 2018

cmsbuild added tests-approved and removed tests-started labels May 22, 2018

cmsbuild added comparison-available and removed comparison-pending labels May 22, 2018

cmsbuild added orp-approved and removed orp-pending labels May 24, 2018

cmsbuild merged commit ff0960a into cms-sw:master May 24, 2018

kreczko mentioned this pull request May 24, 2018

[101X] [L1T][DQMOffline] Fixes for L1T jet DQMOffline #23309

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[L1T][DQMOffline] Fixes for L1T jet DQMOffline #23269

[L1T][DQMOffline] Fixes for L1T jet DQMOffline #23269

kreczko commented May 21, 2018

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

jfernan2 commented May 21, 2018

cmsbuild commented May 21, 2018 •

edited

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

thomreis May 22, 2018

kreczko May 22, 2018

kreczko May 22, 2018

thomreis May 22, 2018

kreczko May 22, 2018

thomreis May 22, 2018

kreczko May 22, 2018

thomreis May 22, 2018

cmsbuild commented May 22, 2018

thomreis commented May 22, 2018

cmsbuild commented May 22, 2018 •

edited

thomreis commented May 22, 2018

kreczko commented May 22, 2018

thomreis commented May 22, 2018

thomreis commented May 22, 2018

dmitrijus commented May 22, 2018

cmsbuild commented May 22, 2018

cmsbuild commented May 22, 2018

cmsbuild commented May 22, 2018

cmsbuild commented May 22, 2018

fabiocos commented May 24, 2018

[L1T][DQMOffline] Fixes for L1T jet DQMOffline #23269

[L1T][DQMOffline] Fixes for L1T jet DQMOffline #23269

Conversation

kreczko commented May 21, 2018

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

jfernan2 commented May 21, 2018

cmsbuild commented May 21, 2018 • edited

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

cmsbuild commented May 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented May 22, 2018

thomreis commented May 22, 2018

cmsbuild commented May 22, 2018 • edited

thomreis commented May 22, 2018

kreczko commented May 22, 2018

thomreis commented May 22, 2018

thomreis commented May 22, 2018

dmitrijus commented May 22, 2018

cmsbuild commented May 22, 2018

cmsbuild commented May 22, 2018

cmsbuild commented May 22, 2018

cmsbuild commented May 22, 2018

fabiocos commented May 24, 2018

cmsbuild commented May 21, 2018 •

edited

cmsbuild commented May 22, 2018 •

edited