Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small updates to relval workflows #23273

Merged
merged 2 commits into from May 24, 2018
Merged

Small updates to relval workflows #23273

merged 2 commits into from May 24, 2018

Conversation

fabozzi
Copy link
Contributor

@fabozzi fabozzi commented May 21, 2018

  • Adjusted job splitting for SingleElectron 2017 data relval
  • Introduced a "Prod" premix workflow for 2018 MC (i.e. same configuration as in MC production)

@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone May 21, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23273/4765

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabozzi for master.

It involves the following packages:

Configuration/PyReleaseValidation

@GurpreetSinghChahal, @cmsbuild, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabozzi
Copy link
Contributor Author

fabozzi commented May 21, 2018

please test workflow 250200.118

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28090/console Started: 2018/05/21 18:05

@cmsbuild
Copy link
Contributor

+1
Tested at: d3f0965
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23273/28090/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23273/28090/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23273/250200.118_ProdZEE_13_pmx25ns+ProdZEE_13UP18+DIGIPRMXUP18_PROD_PU25+RECOPRMXUP18PROD_PU25

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2323 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2901712
  • DQMHistoTests: Total failures: 16174
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2885347
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.352 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): -0.352 KiB SiStrip/MechanicalView
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabozzi
Copy link
Contributor Author

fabozzi commented May 22, 2018

+1

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

please test workflow 250200.118

verify differences

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28137/console Started: 2018/05/23 17:05

@cmsbuild
Copy link
Contributor

+1
Tested at: d3f0965
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23273/28137/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23273/28137/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23273/250200.118_ProdZEE_13_pmx25ns+ProdZEE_13UP18+DIGIPRMXUP18_PROD_PU25+RECOPRMXUP18PROD_PU25

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2319 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2901712
  • DQMHistoTests: Total failures: 14172
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2887349
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.352 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): -0.352 KiB SiStrip/MechanicalView
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

@fabozzi all the DQM changes are in the premixing workflow 250202.181. Are they expected from the modifications of the RECOPRMX18PROD setup? Furthermore, the new wf 250202.118 seems to miss an HARVESTING step, is this the expected behaviour? I doubt...

makortel
makortel reviewed May 24, 2018
View reviewed changes
Configuration/PyReleaseValidation/python/relval_steps.py
steps['ZTT_13UP18']=gen2018('ZTT_All_hadronic_13TeV_TuneCUETP8M1_cfi',Kby(9,80))
steps['H125GGgluonfusion_13UP18']=gen2018('H125GGgluonfusion_13TeV_TuneCUETP8M1_cfi',Kby(9,50))
steps['QQH1352T_13UP18']=gen2018('QQH1352T_13TeV_TuneCUETP8M1_cfi',Kby(9,50))
steps['SMS-T1tttt_mGl-1500_mLSP-100_13UP18']=gen2018('SMS-T1tttt_mGl-1500_mLSP-100_13TeV-pythia8_cfi',Kby(9,50))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiocos This change looks something that could change premixing results.

@fabozzi
Copy link
Contributor Author

fabozzi commented May 24, 2018

@fabiocos

  1. The updated generation step uses 2018 configuration, which is the right thing to do since they are 2018 workflows (I just realized when doing this PR they were still setup to 2017). Since the input gensim of the 250202.181 is updated to 2018, then I do expect changes affecting the workflow.

  2. This behaviour is what we want: it is not only missing the harvesting but also DQM, since in MC production we do not have a DQM sequence

@fabiocos
Copy link
Contributor

@fabozzi @makortel yes, I indeed see differences in the step1 output that justify modifications. Concerning the second point I see your argument, it is similar to wfs 1 , 2 or 3.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 64e8592 into cms-sw:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved pdmv-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_10_2_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fabozzi @cmsbuild @kpedro88 @fabiocos @makortel