New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pixel MergedDeadROCOccupancy Maps to TkMap script #23339
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23339/4839 |
A new Pull Request was created by @arossi83 (Alessandro Rossi) for master. It involves the following packages: DQM/SiStripMonitorClient @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
…ccupancyPlot line color
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23339/4867 |
Pull request #23339 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again. |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@arossi83 the test above is clearly not probing this code. Was this already tested in a standalone way? |
@fabiocos Yes, the code was already tested in a standalone way. As said in the PR comments these changes affect only Offline shifters scripts. |
+1 |
Add Pixel MergedDeadROCOccupancy Maps to TkMap script and FPix panel bug patch (backport to 10_1_X of #23339)
Changes made only on TrackerOffline shifters scripts. No changes on any files related to the production workflow