Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS: strips mapping for 2018 #23356

Merged

Conversation

forthommel
Copy link
Contributor

backport of #23119

This PR updates the mapping for Totem strip detectors for dedicated 90m run.
In more detail: one fiber was damaged and it was swapped with a working one in one of the detector packages that is not installed anymore.

Runs during the alignment fill can be used for the tests, for example run 314277.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2018

A new Pull Request was created by @forthommel (Laurent Forthomme) for CMSSW_10_1_X.

It involves the following packages:

CondFormats/CTPPSReadoutObjects
EventFilter/CTPPSRawToDigi

@perrotta, @arunhep, @cerminar, @cmsbuild, @franzoni, @slava77, @ggovi, @lpernie can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich, @seemasharmafnal, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented May 28, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28240/console Started: 2018/05/28 22:26

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23356/28240/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2498020
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497843
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@arunhep
Copy link
Contributor

arunhep commented May 29, 2018

+1

@ggovi
Copy link
Contributor

ggovi commented May 29, 2018

+1

@slava77
Copy link
Contributor

slava77 commented May 29, 2018

+1

for #23356 21820f3

  • backport looks correct. Changes in this PR will affect 2018 data processing results from the CTPPS RP strip detectors.
    • IIUC these detectors are included in the readout even in the regular high lumi runs (even though the detectors may be parked/away from the beam). @forthommel please correct me if I'm wrong
  • jenkins tests pass and comparisons with the baseline show no differences.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@forthommel
Copy link
Contributor Author

@slava77 correct! even though the strips tackled in this very PR are located in the vertical pots (which are of course safely stored away from the beam at high-lumi...)

@forthommel
Copy link
Contributor Author

@fabiocos Is there anything we can do to help the review for this backport PR?

@fabiocos
Copy link
Contributor

fabiocos commented Jun 1, 2018

@forthommel I plan to merge all the CTPPS related backports together into a single version when we are ready for the move

@forthommel
Copy link
Contributor Author

@fabiocos Many thanks! Let us know whenever you are ready for this big-merge, as I am expecting a rebase needed for the DQM one (#23354) once #23352 is merged.

@perrotta
Copy link
Contributor

perrotta commented Jun 1, 2018 via email

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 6, 2018

Successfully tested and integrated in the Online DQM at P5. https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMP5TagCollector
Merged in master

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2018

+1

@cmsbuild cmsbuild merged commit b311923 into cms-sw:CMSSW_10_1_X Jun 6, 2018
@forthommel forthommel deleted the ctpps-strips_mapping_2018-10_1_X branch June 8, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants