Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking hgh beta star 2018 (101X backport) #23360

Merged

Conversation

robertccms
Copy link
Contributor

Backport of #23238

This pull includes modified parameters for tracking reconstruction to be used for 2018 joint CMS-TOTEM run at high betaStar. The new era Run2_2018_highBetaStar is created with the highBetaStar_2018 modifier, which changes parameters in 8 python files in RecoTracker/IterativeTracking and 2 files in RecoVertex/PrimaryVertexProducer.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2018

A new Pull Request was created by @robertccms for CMSSW_10_1_X.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences
RecoTracker/IterativeTracking
RecoVertex/PrimaryVertexProducer

@perrotta, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented May 28, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28243/console Started: 2018/05/28 23:11

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23360/28243/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2498020
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497843
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jun 4, 2018

+1

  • Faithfull backport of Tracking hgh beta star 2018 #23238, commit-wise and code-wise
  • (From the comments written while signing the original PR now merged in the master):
    • Track reconstruction parameters to be used for the 2018 CMS-TOTEM run at large beta*
      They are defined in a dedicated era, and therefore do not affect normal reco sequences and workflows
    • Comparison with the current tracking show a larger acceptance of low pt particles, which is instrumental for the run on low-pileup events and the reconstruction of soft tracks
    • Overall CPU increase is kind of 5-10% of the total reco time, which is still deemed acceptable for the special runs where this config is required

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 1c1a5a7 into cms-sw:CMSSW_10_1_X Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants