Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mismatched free() / delete / delete [] error reported by valgrind #2343

Merged
merged 1 commit into from Feb 13, 2014

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Feb 6, 2014

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2014

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_0_X.

Fix Mismatched free() / delete / delete [] error reported by valgrind

It involves the following packages:

RecoTauTag/RecoTau

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@wddgit
Copy link
Contributor Author

wddgit commented Feb 10, 2014

Just wondering why no Jenkins test yet for this pull request after 4 days? If there is something I need to do or did wrong, please let me know. This is just a two liner that fixes two serious memory bugs that lead to undefined behavior.

@ktf
Copy link
Contributor

ktf commented Feb 12, 2014

@nclopezo please take care of this.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 12, 2014

+1

signed as of 38d0d60, based on jenkins and ~trivial change in the code

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

+1

nclopezo added a commit that referenced this pull request Feb 13, 2014
Valgrind fixes -- Fix Mismatched free() / delete / delete [] error reported by valgrind
@nclopezo nclopezo merged commit 7f4a8ec into cms-sw:CMSSW_7_0_X Feb 13, 2014
@wddgit wddgit deleted the fixPFTau70X branch May 8, 2014 16:07
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants