Prioritize exception from Paths #23432
Conversation
Use std::move to allow use of a lambda that only has a move constructor and no copy constructor.
When reporting an exception from processing an event, prioritize exceptions originating from a Path over those from EndPaths or from calling accumulators.
|
The code-checks are being triggered in jenkins. |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23432/4972 |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Concurrency @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@smuzaffar are the tests for this pull request stuck? The log has the last entry at 20:00 yesterday. |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: bae6614 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test TestFWCoreFrameworkInputTagFailure had ERRORS |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
comparison-pending
tests-pending
tests-started
and removed
tests-approved
tests-pending
labels
|
-1 Tested at: afa8f9d You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test TestFWCoreFrameworkGlobalStreamOne had ERRORS |
|
Comparison job queued. |
|
The unit test failure is from an assert failing while running cmsRun. Unfortunately, the output of cmsRun is not preserved so it is not possible to see what failed. |
|
@fabiocos this change should only effect what exception message is printed when a job fails. The pull request should have absolutely no effect on jobs that run without a problem. |
|
please test |
|
The tests are being triggered in jenkins. |
|
@fabiocos I reran the unit test locally 50 times and never had a failure. Therefore I feel comfortable saying it was a transient effect. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
When multiple exceptions occur when processing an Event, prioritize the exception originating from a Path over those from EndPaths or Accumulators.
This comes from diagnosing failures coming in the gcc 8 IBs where an exception originating in a Path ultimately leads to missing data which triggers a different exception when running accumulators.