New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.1.X] Add switch to contrain vertex refit to BeamSpot in Alignment PV Validation #23456
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_10_1_X. It involves the following packages: Alignment/OfflineValidation @cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@mmusich this code has been integrated in master based on your validation, and does not give any obvious problem. As far as I can see it does not appear in standard production workflows, please correct me. BTW the input file used by the test looks still a 9_2_X relVal |
that's correct. This PR is mostly for convenience of the aligners to have a 10_1 release with it when validating the next object for production.
do you mean that the test that runs in the unit tests uses: from PhysicsTools.PatAlgos.patInputFiles_cff import filesRelValTTbarPileUpGENSIMRECO ?
but it doens't really matter as long as the dataformat is not broken (I hope that people responsible for |
+1 |
backport of #23448
Greetings,
this PR is meant to introduce a new configuration switch in the Alignment Primary Vertex Validation to allow using the Beam Spot from DB information in the unbiased vertex refit procedure. By default this is switched to
False
, so in normal conditions this addition is completely transparent to the validation procedure.This has been shown to be useful to cross-check the scrutiny of the Full-Track validation of the alignment payload at this Hypernews thread.
See here an example of output validation plot obtained for run 31766 either in standard conditions, forcing the vertex fit with the BS from DB prior to re-computation of BS with the new alignment and forcing the vertex fit with the updated BS.
I profit of this PR also to update the initialization file of the all-in-one meta-data tool adding links to the twiki documentation.