Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12X][change GT] 2018 realistic #23498

Closed

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Jun 5, 2018

SUMMARY

One GT changed: 102X_upgrade2018_realistic_v2
. https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/102X_upgrade2018_realistic_v1/102X_upgrade2018_realistic_v2

Note

. This change is needed for the sample production to derive the G2 calibration for MC in 10.2.X
. Due to a broken paths in the DQM code this PR will fail
. This need to be fixed, because a new release with the updated AlCaReco Trigger bit is needed in order to generate the samples to derive the G2 calibration for MC in 10.2.X

@lpernie
Copy link
Contributor Author

lpernie commented Jun 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28502/console Started: 2018/06/05 23:13

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

A new Pull Request was created by @lpernie (Luca Pernie) for master.

It involves the following packages:

Configuration/AlCa

@arunhep, @cerminar, @cmsbuild, @franzoni, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

-1

Tested at: 934468a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23498/28502/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
10824.0 step5

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018/step5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@lpernie
Copy link
Contributor Author

lpernie commented Jun 6, 2018

Error, need to be fixed by DQM:

Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 06-Jun-2018 00:46:58.767 CEST
%MSG-w Configuration: HLTHighLevel:ALCARECOTkAlMinBiasNOTHLT 06-Jun-2018 00:46:58 CEST Run: 1 Event: 1
none of the requested paths and pattern match any HLT path - no events will be selected
%MSG
----- Begin Fatal Exception 06-Jun-2018 00:47:08 CEST-----------------------
An exception of category 'NoRecord' occurred while
[0] Processing Event run: 1 lumi: 1 event: 1 stream: 0
[1] Running path 'pathALCARECOSiStripCalMinBias'
[2] Calling method for module TrackingMonitor/'ALCARECOSiStripCalMinBiasTrackingDQM'
Exception Message:
No "TransientTrackRecord" record found in the EventSetup.n
Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------
06-Jun-2018 00:47:08 CEST Closed file file:step3.root

@arunhep
Copy link
Contributor

arunhep commented Jun 6, 2018

@schneiml @dmitrijus can you please help us in solving the crash message observed in one of the DQM modules here : https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23498/28502/runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018/step5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018.log

@fabiocos this is a limiting issue now for the delivery of Strips G2 calibration for 10.2.X MC because they need the MC sample with the similar GT provided in this PR and are facing the crash in DQM step.

FYI @mmusich : did you manage to contact Tk-DQM ?

@mmusich
Copy link
Contributor

mmusich commented Jun 6, 2018

@arunhep, I mentioned the issue to @fioriNTU.
It's not completely clear to me, though, who "owns" this module.
A simple patch solving the issue would be this one:

--- a/DQMOffline/CalibTracker/python/ALCARECOSiStripCalMinBiasDQM_cff.py
+++ b/DQMOffline/CalibTracker/python/ALCARECOSiStripCalMinBiasDQM_cff.py
@@ -13,6 +13,7 @@ ALCARECOSiStripCalMinBiasTrackingDQM = DQM.TrackingMonitor.TrackingMonitor_cfi.T
     AlgoName = 'ALCARECO'+__selectionName,
     FolderName = "AlCaReco/"+__selectionName,
     BSFolderName = "AlCaReco/"+__selectionName+"/BeamSpot",
+    MeasurementState = "default",
 # margins and settings
     TkSizeBin = 71,
     TkSizeMin = -0.5,

by the way this MeasurementState parameter is in general set to "default" for the majority of other AlCa-flavoured instances of TrackingMonitor : https://github.com/cms-sw/cmssw/search?l=Python&p=1&q=MeasurementState, but at the moment I don't understand how said module is gladly running in express, prompt, and in data relvals without issues, while failing as soon as a single MC events goes through it.

@lpernie
Copy link
Contributor Author

lpernie commented Jun 7, 2018

Fix made here #23523

@lpernie
Copy link
Contributor Author

lpernie commented Jun 7, 2018

please test with #23523

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28549/console Started: 2018/06/07 20:24

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23498/28549/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902499
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902308
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.64 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -0.328 KiB AlCaReco/SiStripCalMinBias
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@lpernie
Copy link
Contributor Author

lpernie commented Jun 8, 2018

superseeded by #23543

@lpernie lpernie closed this Jun 8, 2018
cmsbuild added a commit that referenced this pull request Jun 11, 2018
Fix for AlCaSiStripCalMinBias as discussed on PR #23498
cmsbuild added a commit that referenced this pull request Jun 12, 2018
…_1_X

[10.1.X] Fix for ALCARECOSiStripCalMinBiasTrackingDQM as discussed on PR #23498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants