Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster counting split in BPix and FPix to HLTPixelActitivityFilter [101X Backport] #23542

Merged

Conversation

JanFSchulte
Copy link
Contributor

Backport of #23541

Another PR for the 90m beta* run, adding the ability to count clusters separately in BPix and FPix in case suppression of noisy clusters in FPix is not available in time.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for CMSSW_10_1_X.

It involves the following packages:

HLTrigger/special

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28593/console Started: 2018/06/09 10:12

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23542/28593/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2522539
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2522362
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

+1

same comments as for #23338 apply

@cmsbuild cmsbuild merged commit 3887f15 into cms-sw:CMSSW_10_1_X Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants