Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 9_4_9_cand1 content on top of 9_4_X as a patch #23549

Merged
merged 1 commit into from Jul 13, 2018

Conversation

fabiocos
Copy link
Contributor

The content of this PR is equivalent to #23474 , but instead of doing a simple "git checkout CMSSW_9_4_X ; git merge CMSSW_9_4_MAOD_X" it is obtained by applying on top of CMSSW_9_4_X the result of the "git diff CMSSW_9_4_X..CMSSW_9_4_MAOD_X".

The result of "git diff --name-only fc-MAODbackport..CMSSW_9_4_MAOD_X" is empty.

In this way the synchronisation of the 94X and 9_4_MAOD_X code happens without jeopardising the commit history (affected by forward ports). For the detailed history of the commits the 9_4_MAOD_X branch can be checked

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_9_4_X.

It involves the following packages:

CommonTools/ParticleFlow
Configuration/AlCa
Configuration/PyReleaseValidation
PhysicsTools/PatAlgos
RecoEgamma/EgammaPhotonProducers
RecoEgamma/EgammaTools

@perrotta, @prebello, @arunhep, @kpedro88, @fabozzi, @cmsbuild, @gpetruc, @franzoni, @cerminar, @slava77, @GurpreetSinghChahal, @pohsun, @monttj, @arizzi, @lpernie can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @felicepantaleo, @jainshilpi, @rappoccio, @Martin-Grunewald, @ahinzmann, @varuns23, @seemasharmafnal, @mmarionncern, @imarches, @makortel, @smoortga, @acaudron, @lgray, @jdolen, @ferencek, @Sam-Harper, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @tocheng, @schoef, @mmusich, @JyothsnaKomaragiri, @mverzett, @cbernet, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28607/console Started: 2018/06/11 11:19

@fabiocos
Copy link
Contributor Author

@smuzaffar @slava77 this is the backport of 9_4_MAOD_X into 9_4_X that avoids messing up the commit history

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23549/28607/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1352 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 2840
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2718491
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 11, 2018

+upgrade

@pohsun
Copy link

pohsun commented Jun 13, 2018

+1

@fabiocos
Copy link
Contributor Author

@slava77 @perrotta @fabozzi @prebello after the validation of 9_4_9_cand2, I think it is simpler to merge this PR, and I will produce one more to backport #23708

@fabozzi
Copy link
Contributor

fabozzi commented Jul 13, 2018

+1

@fabiocos
Copy link
Contributor Author

+1

@fabiocos
Copy link
Contributor Author

merge

after the validation of CMSSW_9_4_9_cand2, merge this PR and then add the difference between cand2 and cand1 on top

@cmsbuild cmsbuild merged commit 68e825f into cms-sw:CMSSW_9_4_X Jul 13, 2018
@fabiocos fabiocos deleted the fc-MAODbackport branch November 2, 2018 14:31
@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Pull request #23549 was updated. @simonepigazzini, @vlimant can you please check and sign again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants