Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.4.X] DeepCSV and CSVv2 negative tagger bugfix #23561

Merged
merged 16 commits into from Jul 3, 2018

Conversation

emilbols
Copy link
Contributor

backport of #23206

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2018

A new Pull Request was created by @emilbols for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/Combined
RecoBTag/SecondaryVertex
RecoVertex/AdaptiveVertexFinder

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @felicepantaleo, @rappoccio, @ahinzmann, @seemasharmafnal, @mmarionncern, @imarches, @makortel, @smoortga, @acaudron, @jdolen, @ferencek, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @ebrondol, @dgulhan, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 11, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28626/console Started: 2018/06/11 18:12

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23561/28626/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 103
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721228
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@slava77
Copy link
Contributor

slava77 commented Jun 12, 2018

+1

for #23561 c67b7d9

This PR is needed for analysis workflows, it does not affect production workflows.
There will be more backport PRs related to Deep* b-taggers and will (at times) depend on the previous backports.
@fabiocos please merge this if there are no issues.

@fabiocos
Copy link
Contributor

fabiocos commented Jul 3, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Jul 3, 2018

merge

@cmsbuild cmsbuild merged commit 5b48f7c into cms-sw:CMSSW_9_4_X Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants