fix header DetectorDescription/DDCMS

[mrodozov]

Fix headers related to #15248.

[cmsbuild]

The code-checks are being triggered in jenkins.

[mrodozov]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23585/5184

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28689/console Started: 2018/06/14 15:37

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

DetectorDescription/DDCMS

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: 7dfaa7a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23585/28689/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found an error when building:

Entering library rule at src/DetectorDescription/DDCMS/plugins
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-14-1100/src/DetectorDescription/DDCMS/plugins/DDCMSDetElementCreator.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-14-1100/src/DetectorDescription/DDCMS/plugins/DDTestDumpFile.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-14-1100/src/DetectorDescription/DDCMS/plugins/DDAngular.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-14-1100/src/DetectorDescription/DDCMS/plugins/DDAngular.cc:2:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-14-1100/src/DetectorDescription/DDCMS/interface/DDPlugins.h:22:24: error: using typedef-name '{anonymous}::ns::xml_h' after 'class'
   namespace ns { class xml_h; }
                        ^~~~~
In file included from /cvmfs/cms-ib.cern.ch/nweek-02528/slc6_amd64_gcc630/external/dd4hep/v01-07x-gnimlf6/include/XML/Helper.h:19:0,
                 from /cvmfs/cms-ib.cern.ch/nweek-02528/slc6_amd64_gcc630/external/dd4hep/v01-07x-gnimlf6/include/DD4hep/DetFactoryHelper.h:18,
                 from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-14-1100/src/DetectorDescription/DDCMS/plugins/DDAngular.cc:1:


• Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 16 COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-14-1100/src/DetectorDescription/DDCMS/plugins/DDTIBLayerAlgo.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-14-1100/src/DetectorDescription/DDCMS/plugins/DDTIDRingAlgo.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-14-1100/src/DetectorDescription/DDCMS/plugins/DDTOBRadCableAlgo.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-14-1100/src/DetectorDescription/DDCMS/plugins/DDTrackerZPosAlgo.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-14-1100/src/DetectorDescription/DDCMS/plugins/DDTrackerPhiAlgo.cc:2:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-14-1100/src/DetectorDescription/DDCMS/interface/DDPlugins.h:22:24: error: definition of type 'xml_h' conflicts with typedef of the same name
  namespace ns { class xml_h; }
                       ^
/cvmfs/cms-ib.cern.ch/nweek-02528/slc6_amd64_gcc630/external/dd4hep/v01-07x-gnimlf6/include/DD4hep/Factories.h:202:41: note: 'xml_h' declared here
    typedef dd4hep::xml::Handle_t       xml_h;
                                        ^


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[mrodozov]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23585/5189

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28696/console Started: 2018/06/14 16:40

[cmsbuild]

Pull request #23585 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again.

[cmsbuild]

+1
Tested at: c31e25e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23585/28696/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23585/28696/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902004
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901812
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1