-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecal shape db #23600
Merged
Merged
Ecal shape db #23600
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b3a228f
ECAL Pulse Shape in Simulation, supporting sub-nanosecond precision a…
theofil 3f7f1ac
ECAL Pulse Shape in Simulation, supporting sub-nanosecond precision a…
theofil d2b19a3
ECAL Pulse Shape in Simulation, supporting sub-nanosecond precision a…
theofil 869540f
ECAL Pulse Shape in Simulation, supporting sub-nanosecond precision a…
theofil d6882f1
code quality checks
theofil a5edf40
removing using std namespace from header file to comply with the CMSS…
theofil 9ff01a2
removing declarations of basic types from CondFormats/EcalObjects/src…
theofil 3f15b8f
adding unit test for EcalSimPulseShape testSerialization
theofil 47750f9
implementing comments from Kevin Pedro on the PR
theofil 9ca9de4
addressing missed comments from Kevin Perdo
theofil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
#ifndef ECALSIMPULSESHAPESRCD_H | ||
#define ECALSIMPULSESHAPESRCD_H | ||
|
||
#include "FWCore/Framework/interface/EventSetupRecordImplementation.h" | ||
class EcalSimPulseShapeRcd : public edm::eventsetup::EventSetupRecordImplementation<EcalSimPulseShapeRcd> {}; | ||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#include "CondFormats/DataRecord/interface/EcalSimPulseShapeRcd.h" | ||
#include "FWCore/Framework/interface/eventsetuprecord_registration_macro.h" | ||
|
||
EVENTSETUP_RECORD_REG(EcalSimPulseShapeRcd); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
#ifndef CondFormats_EcalObjects_EcalSimPulseShape_hh | ||
#define CondFormats_EcalObjects_EcalSimPulseShape_hh | ||
|
||
#include "CondFormats/Serialization/interface/Serializable.h" | ||
#include <vector> | ||
|
||
class EcalSimPulseShape{ | ||
|
||
public: | ||
EcalSimPulseShape(){}; | ||
~EcalSimPulseShape(){}; | ||
void setTimeInterval(float x){time_interval=x;}; | ||
float getTimeInterval(){return time_interval;}; | ||
|
||
|
||
std::vector<double> barrel_shape; // there is no need to getters/setters, just access data directly | ||
std::vector<double> endcap_shape; // there is no need to getters/setters, just access data directly | ||
std::vector<double> apd_shape; // there is no need to getters/setters, just access data directly | ||
|
||
double barrel_thresh; | ||
double endcap_thresh; | ||
double apd_thresh; | ||
float time_interval; // time interval of the shape | ||
|
||
COND_SERIALIZABLE; | ||
}; | ||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
#include "CondFormats/EcalObjects/interface/EcalSimPulseShape.h" |
4 changes: 4 additions & 0 deletions
4
CondFormats/EcalObjects/src/T_EventSetup_EcalSimPulseShape.cc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#include "CondFormats/EcalObjects/interface/EcalSimPulseShape.h" | ||
#include "FWCore/Utilities/interface/typelookup.h" | ||
TYPELOOKUP_DATA_REG(EcalSimPulseShape); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unnecessary white space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done