Handle any trailing white space #23611
Conversation
In boost 1.67, the part of the parser which finds enum values is being passed any trailing white spaces that follow the enum. We now explicitly remove any extra characters.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23611/5230 |
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CommonTools/Utils @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| // end | ||
| if(*(end-1) != *begin) { | ||
| --end; | ||
| } |
There was a problem hiding this comment.
do I understand correctly that this can not be ported to another release using another boost version .. and may resurface as a problem if a future version of boost changes behavior?
Perhaps a more explicit check on the boost version is more appropriate.
There was a problem hiding this comment.
also, I'm missing where exactly is the updated logic matching the extra white space in an explicit way.
There was a problem hiding this comment.
This change will work properly with boost new and old. The updated unit tests to cover the newly discovered problem checks that.
This change makes sure that the end dilimiter matches the beginning delimiter found by the parser. For the old version of boost, or when there is no trailing white space, the if is satisfied immediately.
There was a problem hiding this comment.
ah. I should assume here already that *begin is the opening delimiter.
OK.
|
+1 |
|
merge |
In boost 1.67, the part of the parser which finds enum values
is being passed any trailing white spaces that follow the enum.
We now explicitly remove any extra characters.